Closed Bug 735064 Opened 9 years ago Closed 9 years ago

Add tests for BrowserProvider batch operations

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(blocking-fennec1.0 -)

RESOLVED FIXED
Firefox 15
Tracking Status
blocking-fennec1.0 --- -

People

(Reporter: gcp, Assigned: gcp)

References

Details

Attachments

(1 file)

Extend Bug 734177 with the tests for bug 721352.
Assignee: nobody → gpascutto
Depends on: 721352, 734177
OS: Windows Vista → Android
Hardware: x86_64 → ARM
Getting test in is good but not blocking.
blocking-fennec1.0: --- → -
Attachment #626474 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 626474 [details] [diff] [review]
Patch 1. Add batch tests to BrowserProvider test

Review of attachment 626474 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: mobile/android/base/tests/testBrowserProvider.java.in
@@ +374,5 @@
> +
> +                if (!cursor.moveToFirst())
> +                    allFound = false;
> +                cursor.close();
> +            }

Maybe apply a batch of delete/update operations just to test different operations too?
Attachment #626474 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/2ee762b1d9b2
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.