Add tests for BrowserProvider batch operations

RESOLVED FIXED in Firefox 15

Status

()

Firefox for Android
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gcp, Assigned: gcp)

Tracking

Trunk
Firefox 15
ARM
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking-fennec1.0 -)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Extend Bug 734177 with the tests for bug 721352.
(Assignee)

Updated

6 years ago
Assignee: nobody → gpascutto
Depends on: 721352, 734177
(Assignee)

Updated

6 years ago
OS: Windows Vista → Android
Hardware: x86_64 → ARM
Getting test in is good but not blocking.
blocking-fennec1.0: --- → -
(Assignee)

Comment 2

6 years ago
Created attachment 626474 [details] [diff] [review]
Patch 1. Add batch tests to BrowserProvider test
Attachment #626474 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 626474 [details] [diff] [review]
Patch 1. Add batch tests to BrowserProvider test

Review of attachment 626474 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: mobile/android/base/tests/testBrowserProvider.java.in
@@ +374,5 @@
> +
> +                if (!cursor.moveToFirst())
> +                    allFound = false;
> +                cursor.close();
> +            }

Maybe apply a batch of delete/update operations just to test different operations too?
Attachment #626474 - Flags: review?(lucasr.at.mozilla) → review+
(Assignee)

Comment 4

6 years ago
Pushed with update/delete tests added.

https://tbpl.mozilla.org/?tree=Try&rev=8df01b104d0e

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ee762b1d9b2
https://hg.mozilla.org/mozilla-central/rev/2ee762b1d9b2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.