735064 - Add tests for BrowserProvider batch operations

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Extend Bug 734177 with the tests for bug 721352.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Getting test in is good but not blocking.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Add batch tests to BrowserProvider test

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 626474 [details] [diff] [review]
Patch 1. Add batch tests to BrowserProvider test

Review of attachment 626474 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: mobile/android/base/tests/testBrowserProvider.java.in
@@ +374,5 @@
> +
> +                if (!cursor.moveToFirst())
> +                    allFound = false;
> +                cursor.close();
> +            }

Maybe apply a batch of delete/update operations just to test different operations too?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Pushed with update/delete tests added.

https://tbpl.mozilla.org/?tree=Try&rev=8df01b104d0e

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ee762b1d9b2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ee762b1d9b2