The default bug view has changed. See this FAQ.

B2G RIL: Change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING for consistency

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kanru, Assigned: hsinyi)

Tracking

unspecified
mozilla14
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
CALL_STATE_RINGING is confusing. It looks like the caller side is ringing but actually it is notifying the carrier (the callee side) a new call. Changing it to CALL_STATE_ALERTING not only matches it with rild state but also provides consistence with RIL terminology.

Updated

5 years ago
Assignee: nobody → htsai
Good point, make it so!
Summary: Change CALL_STATE_RINGING in nsIRadioInterfaceLayer.idl to CALL_STATE_ALERTING to match underlying rild state → B2G RIL: Change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING for consistency
(Assignee)

Comment 2

5 years ago
Created attachment 605665 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

I have changed CALL_STATE_RINGING to CALL_STATE_ALERTING and related terms.
Comment on attachment 605665 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Please request review when you upload a patch. Thanks!
Attachment #605665 - Flags: review?(philipp)
Comment on attachment 605665 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Wait, I thought this was only about nsIRadioInterfaceLayer. Now you're also changing the WebTelephony API. We should discuss the latter change on dev-webapi first since it has implications for the users of the API (Gaia being just one of them). Please start a thread there. Thanks!

Apart from that, you need to update an interface's UUID each time you change it, so r- for that.
Attachment #605665 - Flags: review?(philipp) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 605715 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Thanks for the comment.
In this patch, I only made changes about nsIRadioInterfaceLayer, instead of WebTelephony API. Also updated the UUID of the modified interface.

I started a new thread about changing WebTelephony API on dev-webapi. Let's wait for other's comments there.
Attachment #605665 - Attachment is obsolete: true
Attachment #605715 - Flags: review?(philipp)
Comment on attachment 605715 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Looks good! r=me
Attachment #605715 - Flags: review?(philipp) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Due to the very likely merge conflict from bug 735017, I'm going to handle the check in for this patch, so I'm removing the checkin-needed flag.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f378bd681310
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.