735165 - B2G RIL: Change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING for consistency

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

CALL_STATE_RINGING is confusing. It looks like the caller side is ringing but actually it is notifying the carrier (the callee side) a new call. Changing it to CALL_STATE_ALERTING not only matches it with rild state but also provides consistence with RIL terminology.

Comment 1

[Philipp von Weitershausen [:philikon]]

Good point, make it so!

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

I have changed CALL_STATE_RINGING to CALL_STATE_ALERTING and related terms.

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 605665 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Please request review when you upload a patch. Thanks!

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 605665 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Wait, I thought this was only about nsIRadioInterfaceLayer. Now you're also changing the WebTelephony API. We should discuss the latter change on dev-webapi first since it has implications for the users of the API (Gaia being just one of them). Please start a thread there. Thanks!

Apart from that, you need to update an interface's UUID each time you change it, so r- for that.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Thanks for the comment.
In this patch, I only made changes about nsIRadioInterfaceLayer, instead of WebTelephony API. Also updated the UUID of the modified interface.

I started a new thread about changing WebTelephony API on dev-webapi. Let's wait for other's comments there.

Comment 6

[Philipp von Weitershausen [:philikon]]

Comment on attachment 605715 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Looks good! r=me

Comment 7

[Philipp von Weitershausen [:philikon]]

Due to the very likely merge conflict from bug 735017, I'm going to handle the check in for this patch, so I'm removing the checkin-needed flag.

Comment 8

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/f378bd681310