735166 - Intermittent timeout in browser_newtab_bug734043.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Disabled browser_newtab_bug734043.js temporarily to not block the new tab re-layout.

https://hg.mozilla.org/integration/fx-team/rev/bf608f9ed9ca
https://hg.mozilla.org/integration/fx-team/rev/7c8fff2651f5

... and merged ...

https://hg.mozilla.org/mozilla-central/rev/bf608f9ed9ca
https://hg.mozilla.org/mozilla-central/rev/7c8fff2651f5

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Trivial patch. Ensured that the test still fails without the patch for bug 734043 applied.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Try run looks good (no occurrence): https://tbpl.mozilla.org/?tree=Try&rev=87d574ee8021

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 606227 [details] [diff] [review]
patch v1

Review of attachment 606227 [details] [diff] [review]:
-----------------------------------------------------------------

i don't understand the context for this patch. it was not actually testing the grid before?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

I had to disable the test after landing the new layout because it was failing intermittently. The checkGrid() call is just some extra sugar. The essence of this patch is removing the executeSoon() calls between key presses because we don't need it and it lets us time out intermittently if the page got already updated in the meantime.

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 606227 [details] [diff] [review]
patch v1

Review of attachment 606227 [details] [diff] [review]:
-----------------------------------------------------------------

ok, thanks for clarifying

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/7777246f1146

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/7777246f1146