Closed
Bug 735166
Opened 12 years ago
Closed 12 years ago
Intermittent timeout in browser_newtab_bug734043.js
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 14
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.11 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Disabled browser_newtab_bug734043.js temporarily to not block the new tab re-layout. https://hg.mozilla.org/integration/fx-team/rev/bf608f9ed9ca https://hg.mozilla.org/integration/fx-team/rev/7c8fff2651f5 ... and merged ... https://hg.mozilla.org/mozilla-central/rev/bf608f9ed9ca https://hg.mozilla.org/mozilla-central/rev/7c8fff2651f5
Assignee | ||
Comment 2•12 years ago
|
||
Trivial patch. Ensured that the test still fails without the patch for bug 734043 applied.
Assignee | ||
Comment 3•12 years ago
|
||
Try run looks good (no occurrence): https://tbpl.mozilla.org/?tree=Try&rev=87d574ee8021
Comment 4•12 years ago
|
||
Comment on attachment 606227 [details] [diff] [review] patch v1 Review of attachment 606227 [details] [diff] [review]: ----------------------------------------------------------------- i don't understand the context for this patch. it was not actually testing the grid before?
Assignee | ||
Comment 5•12 years ago
|
||
I had to disable the test after landing the new layout because it was failing intermittently. The checkGrid() call is just some extra sugar. The essence of this patch is removing the executeSoon() calls between key presses because we don't need it and it lets us time out intermittently if the page got already updated in the meantime.
Comment 6•12 years ago
|
||
Comment on attachment 606227 [details] [diff] [review] patch v1 Review of attachment 606227 [details] [diff] [review]: ----------------------------------------------------------------- ok, thanks for clarifying
Attachment #606227 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7777246f1146
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7777246f1146
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•