Closed Bug 735191 Opened 9 years ago Closed 9 years ago

shared-libraries-win32.cc fails to crosscompile on case-sensitive OSes

Categories

(Core :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
It's because it includes <Dbghelp.h>. On Windows it doesn't matter, but mingw requires lower-case on case-sensitive OSes. While I was at this I did a tiny clean up (fixed a warning about extra ';' and removed magic numbers).
Attachment #605338 - Flags: review?(ehsan)
Comment on attachment 605338 [details] [diff] [review]
fix v1.0

Review of attachment 605338 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit below.

::: tools/profiler/sps_sampler.h
@@ +182,5 @@
>      }
>      if (!aMarker) {
>        return; //discard
>      }
> +    if (mMarkerPointer == sizeof(mMarkerPointer)) {

Please use mozilla::ArrayLength here and below.
Attachment #605338 - Flags: review?(ehsan) → review+
Thanks for the review. Pushed fixed version to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8cafe95ef83
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/d8cafe95ef83
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla14
Depends on: 737667
You need to log in before you can comment on or make changes to this bug.