shared-libraries-win32.cc fails to crosscompile on case-sensitive OSes

RESOLVED FIXED in mozilla14

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla14
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 605338 [details] [diff] [review]
fix v1.0

It's because it includes <Dbghelp.h>. On Windows it doesn't matter, but mingw requires lower-case on case-sensitive OSes. While I was at this I did a tiny clean up (fixed a warning about extra ';' and removed magic numbers).
Attachment #605338 - Flags: review?(ehsan)
Comment on attachment 605338 [details] [diff] [review]
fix v1.0

Review of attachment 605338 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit below.

::: tools/profiler/sps_sampler.h
@@ +182,5 @@
>      }
>      if (!aMarker) {
>        return; //discard
>      }
> +    if (mMarkerPointer == sizeof(mMarkerPointer)) {

Please use mozilla::ArrayLength here and below.
Attachment #605338 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

6 years ago
Thanks for the review. Pushed fixed version to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8cafe95ef83
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/d8cafe95ef83
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla14
Depends on: 737667
You need to log in before you can comment on or make changes to this bug.