Closed
Bug 73520
Opened 24 years ago
Closed 24 years ago
User agent field reports it as 0.8.1. should be 0.9
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla.mozilla.org, Assigned: leaf)
References
()
Details
Attachments
(1 file)
1.70 KB,
patch
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.2-ac20 i686; en-US; 0.8.1)
BuildID: 2001032608
When submitting another bugreport I noticed that the user agent field says 0.8.1
when it should say 0.9 (acording to bz on #mozillazine ;)
Reproducible: Always
Steps to Reproduce:
1.go to the bug report page (or whatever other means you have of looking at the
user agent field) and oogle
2.
3.
Actual Results: Mozilla/5.0 (X11; U; Linux 2.4.2-ac20 i686; en-US; 0.8.1)
Expected Results: Mozilla/5.0 (X11; U; Linux 2.4.2-ac20 i686; en-US; 0.9)
(i assume)
Comment 1•24 years ago
|
||
as far as i'm concerned trunk builds should have a null version
and the version should only be set until after the branch.
Comment 2•24 years ago
|
||
I'd suggest "trunk" to match the directory milestone name and only change it to
a number on that release branch.
reassign to leaf, qa to asa.
Assignee: cls → leaf
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: granrose → asa
Comment 3•24 years ago
|
||
I thought we decided on 0.8.1+ ? Without a Gecko pulldate we'd be really lost
on bug reports if we didn't have at least a ball-park guess of the user agent
I've also gotten no feedback on my search to find out what happened to the
original "prv:" unique-ish tag that was originally proposed for this, to make
pulling the version out of the UA programmatically easier. I've put a modified
form of this in the attached patch. 'rv:' (release version) should be unique
enough and less ugly than the originally proposed 'prv:' (pre-release version)
or 'mrv:' (Mozilla release version)
Note how clean the about.html code becomes, and less error-prone. The current
code would break under many many circumstances. If someone added a
general.useragent.vendorComment pref (as Beonex or Netscape might) then the
about.html would show half the UA as the "version". If the mozilla comment had
a field added after the version (and our current spec allows for it) then that
would be picked up as the "version" since it would be the last ';'.
If someone overrides the user agent entirely then we don't know what version
this is, but the code fails gracefully and the about page will say simply
"Mozilla".
seeking r=/sr=
Comment 4•24 years ago
|
||
Assignee | ||
Comment 5•24 years ago
|
||
r=leaf, did you send mail to reviewers@mozilla.org already?
Comment 6•24 years ago
|
||
taking the bug since I've written the patch
Comment 7•24 years ago
|
||
Damn Mozilla and it's "lose form data on back button" feature
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•