735262 - Make leaf address profiling saner

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Make leaf address profiling saner

We don't need to store an mLeafAddress field for each profile entry. Instead just add a 'l' tag for the leaf entries.

Comment 1

[Benoit Girard (:BenWa)]

Comment on attachment 605410 [details] [diff] [review]
Make leaf address profiling saner

I think you're missing a ENABLE_SPS_LEAF_DATA near 'aProfile.addTag(ProfileEntry('l', sample->pc));'

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/acefe9a94a63
https://hg.mozilla.org/mozilla-central/rev/aaa7f8a1945c

Comment 3

[Marco Bonardo [:mak]]

ehr was backed out. please annotate changes to the bugs.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/773b2db48d0c

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm seeing in my local build:

In member function ‘void TableTicker::doBacktrace(ThreadProfile&, TickSample*)’:
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:462:48: error: no matching function for call to ‘ProfileEntry::ProfileEntry(char, const char [7], int)’
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:462:48: note: candidates are:
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:141:3: note: ProfileEntry::ProfileEntry(char, Address)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:141:3: note:   candidate expects 2 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:136:3: note: ProfileEntry::ProfileEntry(char, uintptr_t)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:136:3: note:   candidate expects 2 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:131:3: note: ProfileEntry::ProfileEntry(char, double)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:131:3: note:   candidate expects 2 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:126:3: note: ProfileEntry::ProfileEntry(char, const char*)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:126:3: note:   candidate expects 2 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:120:3: note: ProfileEntry::ProfileEntry()
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:120:3: note:   candidate expects 0 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:117:7: note: constexpr ProfileEntry::ProfileEntry(const ProfileEntry&)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:117:7: note:   candidate expects 1 argument, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:117:7: note: constexpr ProfileEntry::ProfileEntry(ProfileEntry&&)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:117:7: note:   candidate expects 1 argument, 3 provided

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed bustage fix after brief discussion with jrmuizel on irc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb484a084008

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/773b2db48d0c
https://hg.mozilla.org/mozilla-central/rev/bb484a084008

Comment 8

[(no longer active)]

This broke the profiling branch, I fixed it in https://hg.mozilla.org/mozilla-central/rev/fe91ab23b390