The default bug view has changed. See this FAQ.

Make leaf address profiling saner

RESOLVED FIXED in mozilla14

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla14
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 605410 [details] [diff] [review]
Make leaf address profiling saner

We don't need to store an mLeafAddress field for each profile entry. Instead just add a 'l' tag for the leaf entries.
Attachment #605410 - Flags: review?(bgirard)
Comment on attachment 605410 [details] [diff] [review]
Make leaf address profiling saner

I think you're missing a ENABLE_SPS_LEAF_DATA near 'aProfile.addTag(ProfileEntry('l', sample->pc));'
Attachment #605410 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/acefe9a94a63
https://hg.mozilla.org/mozilla-central/rev/aaa7f8a1945c

Updated

5 years ago
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
ehr was backed out. please annotate changes to the bugs.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/773b2db48d0c
I'm seeing in my local build:

In member function ‘void TableTicker::doBacktrace(ThreadProfile&, TickSample*)’:
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:462:48: error: no matching function for call to ‘ProfileEntry::ProfileEntry(char, const char [7], int)’
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:462:48: note: candidates are:
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:141:3: note: ProfileEntry::ProfileEntry(char, Address)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:141:3: note:   candidate expects 2 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:136:3: note: ProfileEntry::ProfileEntry(char, uintptr_t)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:136:3: note:   candidate expects 2 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:131:3: note: ProfileEntry::ProfileEntry(char, double)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:131:3: note:   candidate expects 2 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:126:3: note: ProfileEntry::ProfileEntry(char, const char*)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:126:3: note:   candidate expects 2 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:120:3: note: ProfileEntry::ProfileEntry()
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:120:3: note:   candidate expects 0 arguments, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:117:7: note: constexpr ProfileEntry::ProfileEntry(const ProfileEntry&)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:117:7: note:   candidate expects 1 argument, 3 provided
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:117:7: note: constexpr ProfileEntry::ProfileEntry(ProfileEntry&&)
/home/dbaron/builds/ssd/mozilla-central/mozilla/tools/profiler/TableTicker.cpp:117:7: note:   candidate expects 1 argument, 3 provided
Landed bustage fix after brief discussion with jrmuizel on irc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb484a084008
https://hg.mozilla.org/mozilla-central/rev/773b2db48d0c
https://hg.mozilla.org/mozilla-central/rev/bb484a084008
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
This broke the profiling branch, I fixed it in https://hg.mozilla.org/mozilla-central/rev/fe91ab23b390
You need to log in before you can comment on or make changes to this bug.