735278 - Linker doesn't call fini_array function in reverse order of those of init_array

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Call destructors in reverse order of initializers in the linker

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 629776 [details] [diff] [review]
Call destructors in reverse order of initializers in the linker

Review of attachment 629776 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/linker/Utils.h
@@ +536,5 @@
> +   * Returns a reverse iterator pointing past the beginning of the Array
> +   */
> +  reverse_iterator rend() const {
> +    if (length)
> +      return reverse_iterator(UnsizedArray<T>::operator[](-1));

I don't like this because it screws with bounds checking (which I realize is unimplemented, and we don't run static analyses for it) and also because I'm fairly certain that the ultimate effect of this produces undefined behavior according to the standard.  (Pointers just past the end of an object are OK; pointers before the beginning of an object are not.)  Rewrite to avoid this, please.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Call destructors in reverse order of initializers in the linker

I also slipped a fix to the operator++ return type.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d03872d8e1b4

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d03872d8e1b4