735281 - Remove the security check in XPCWrappedNative::CallMethod

Status: RESOLVED INACTIVE

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Currently, we have a security check in XPCWrappedNative::CallMethod. It used to be the core security check in the browser (in addition to the checks in all of the random global objects, random checks in the engine and random checks elsewhere in the browser). Ever since brain transplants/compartments, however, it's been mostly unused, as we've moved to an object capabilities-like approach, with membranes providing the security checks at the boundaries between trust domains.

This means that we *should* be able to remove the security check in XPCWrappedNative::CallMethod (or at least turn it into an assertion). I know personally of one case that depends on it (bug 735280). Are there any others? If so, we should get bugs filed on them and fix them.

Comment 1

[Gabor Krizsanits (INACTIVE)]

So I've been playing around with a patch for bug 735280 and I turned this check into an assertion. So far only the /tests/dom/tests/mochitest/bugs/test_bug664737.html test hit the assertion, with the history object.

Comment 2

[Gabor Krizsanits (INACTIVE)]

Actually the above mentioned test is not a real failure, only the error message changed so it's just something to fix on the test side.

Comment 3

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.