735303 - Useless basic layer painting on OMTC

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

When Benoit measured this he saw 3ms. I see 3% of painting time been spent doing this.

To fix this we need to separate validation from compositing.

Comment 1

[Bas Schouten (:bas.schouten)]

Validation should happen in a generic 'ShadowLayer' tree which is factored out separately from BasicLayers (or any of the other composition layer managers). So that we have minimal usage of code on the 'content' side that just deals with validation. And we will also end up with cleaner BasicLayers code.

Comment 3

[Joe Drew (not getting mail)]

Frig.

Comment 4

[Joe Drew (not getting mail)]

We have a 16x16 dummy surface that we composite to while validating, AIUI, and that needs to be entirely removed. That being said, I don't think this needs to block.

Comment 5

[Benoit Girard (:BenWa)]

This has been further reduce with TiledThebesLayer. I don't really think this bug is important.

Comment 6

[Oleg Romashin (:romaxa)]

isn't this bug already fixed by 757380 and some older bug?

Comment 7

[JP Rosevear [:jpr]]

Benoit, do you have any thoughts on #6?

Comment 8

[Benoit Girard (:BenWa)]

This isn't fixed since we still try to draw. We have several things in place to make that drawing fix but I don't think it will go away until we refactor how we do layers and OMTC.