735329 - Download manager doesn't finalise its statement

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[[e-mail]]

As per bug 713172, the sanitiser is unable to sanitise downloads if the download manager's connection remains open. All known cases where this happens were fixed for Firefox 12, and a fatal assertion added was added to enforce this. SeaMonkey however trips over this fatal assertion if the download manager is opened.

Comment 1

[[e-mail]]

Attachment: Proposed patch [Checkin: Comment 6]

Comment 2

[Ian Neal]

Comment on attachment 605455 [details] [diff] [review]
Proposed patch [Checkin: Comment 6]

So the key change is moving from .reset() to .finalize()?
That looks like the right thing to do so r=me

Comment 3

[[e-mail]]

Pushed changeset cdc68c902088 to comm-central.

Comment 4

[[e-mail]]

Comment on attachment 605455 [details] [diff] [review]
Proposed patch [Checkin: Comment 6]

[Approval Request Comment]
Regression caused by (bug #): 472001
User impact if declined: potential dataloss because connection is never closed
Testing completed (on m-c, etc.): debug builds no longer crash on shutdown
Risk to taking this patch (and alternatives if risky): low; the fix itself is the reset/finalize change, which should work even without the variable change, but I didn't see the point of keeping a finalized statement hanging around.
String changes made by this patch: none

Comment 5

[Robert Kaiser]

Comment on attachment 605455 [details] [diff] [review]
Proposed patch [Checkin: Comment 6]

Not adding another review, it has one already, but it's good for the branches, I think. I don't see though how a SELECT that isn't finalized can result in dataloss.

That said, this unfortunately goes a different way than what I did for my add-on, where I made this use an async query, which doesn't need resetting or finalizing at all.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 605455 [details] [diff] [review]
Proposed patch [Checkin: Comment 6]

http://hg.mozilla.org/releases/comm-aurora/rev/6aa9ff8a7d5d
http://hg.mozilla.org/releases/comm-beta/rev/78298359ec1e