Last Comment Bug 735401 - (LA-picpasso) PicPasso add-on creates zombie compartments
(LA-picpasso)
: PicPasso add-on creates zombie compartments
Status: RESOLVED FIXED
[MemShrink:P3]
:
Product: Tech Evangelism
Classification: Other
Component: Add-ons (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
https://addons.mozilla.org/addon/picp...
Depends on:
Blocks: LeakyAddons ZombieCompartments
  Show dependency treegraph
 
Reported: 2012-03-13 12:44 PDT by Kris Maglione [:kmag]
Modified: 2012-06-28 13:46 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description User image Kris Maglione [:kmag] 2012-03-13 12:44:07 PDT
The PicPasso add-on creates zombie compartments after clicking its toolbar button. The following steps create a zombie compartment, but they may not be the only way to do so, and not all of the steps may be required:

1) Visit http://gmail.com/
2) Press the PicPasso toolbar button (at this point, security is broken for the page)
3) Close the tab

After minimizing memory multiple times, the following related compartments remain:

    http://googleads.g.doubleclick.net/pagead/viewthroughconversion/1015888343/?random=1331667169853&cv=7&fst=1331667169853&num=1&fmt=2&value=0&label=aV-CCKGCwgIQ1_O05AM&bg=ffffff&hl=en&guid=ON&u_h=800&u_w=1280&u_ah=800&u_aw=1280&u_cd=24&u_his=1&u_tz=-240&u_java=true&u_nplug=12&u_nmime=199&url=http%3A//www.picpasso.com/register&ctc_id=CAIVAgAAAB0CAAAA&ct_cookie_present=false [pid=Main]

    https://accounts.google.com/ServiceLogin?service=mail&passive=true&rm=false&continue=http://mail.google.com/mail/&scc=1&ltmpl=default&ltmplcache=2 [pid=Main]

Author CCed.
Comment 1 User image Andrew Williamson [:eviljeff] 2012-03-28 09:34:00 PDT
Jan: is there any update you can give us on fixing these memory leaks?
Comment 2 User image Jan Schnitzler 2012-03-29 03:45:52 PDT
The developer could not reconstruct the memory leaks in Firefox 11, but is currently trying to solve it. I will let you know, if I hear more from him.
Comment 3 User image Andrew Williamson [:eviljeff] 2012-04-12 08:35:55 PDT
Jan: did the developer manage to solve the problem?
Comment 4 User image Jan Schnitzler 2012-04-16 08:04:13 PDT
We cannot reconstruct the zombie compartment. Therefore we canot really solve it... Would it be OK to upload a new update, which can be tested again?
Comment 5 User image Andrew Williamson [:eviljeff] 2012-04-16 08:08:01 PDT
(In reply to Jan Schnitzler from comment #4)
> We cannot reconstruct the zombie compartment. Therefore we canot really
> solve it... Would it be OK to upload a new update, which can be tested again?

If you can't reproduce with your current version with the steps in Comment #0 then yes.  We will check it again.
Comment 6 User image Jorge Villalobos [:jorgev] 2012-04-26 15:18:01 PDT
Jan, are you working on an update for us to test?
Comment 7 User image Jan Schnitzler 2012-04-28 00:43:36 PDT
We are currently working on it and i hope we can submit it next week. Sorry for the delay...
Comment 8 User image Andrew Williamson [:eviljeff] 2012-05-23 08:26:56 PDT
Jan: I see your latest version was reviewed and the editor still found the leak - do you not see the leak with the steps to reproduce in Comment #0?
Comment 9 User image Igor Fischer 2012-06-04 11:49:50 PDT
Hello all, I'm Igor, the principal developer. Jan is away, so I'll take over.

As Jan said, I followed the steps from Comment #0 but could not reproduce the memory leak.

1. When I start Firefox, I see only one PicPasso-related compartment: picPasso.sqlite.

2. After opening gmail.com, a number of PicPasso-related compartments appear, mainly inner windows with the uri about:blank (for PicPasso's own windows), but also some external.

3. However, when I close the Gmail tab, reopen about:memory and click 10 times on "Minimize memory usage", I see no PicPasso compartements, except the picPasso.sqlite. There are some inner windows, but, to my understanding, they belong to firebug.

Is there a possibility to post screenshots?
Comment 10 User image Nicholas Nethercote [:njn] 2012-06-04 16:15:24 PDT
Igor, which version of Firefox are you using?  If it's FF15, the fix in bug 695480 might be preventing the zombie compartment from manifesting.
Comment 11 User image Igor Fischer 2012-06-04 21:15:59 PDT
(In reply to Nicholas Nethercote [:njn] from comment #10)
> Igor, which version of Firefox are you using?  If it's FF15, the fix in bug
> 695480 might be preventing the zombie compartment from manifesting.

I'm using Firefox 12 and am referring to PicPasso 1.0.18, i.e. the new version.
Comment 12 User image Kris Maglione [:kmag] 2012-06-28 13:46:06 PDT
I can no longer reproduce this issue.

Note You need to log in before you can comment on or make changes to this bug.