Last Comment Bug 735419 - gfxTextRun constructor has unused parameter 'aText'
: gfxTextRun constructor has unused parameter 'aText'
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
: P5 normal (vote)
: mozilla14
Assigned To: Jonathan Kew (:jfkthame)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-13 13:19 PDT by Scott Johnson (:jwir3)
Modified: 2012-03-16 05:55 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
eliminate unused parameter in the gfxTextRun constructor (10.62 KB, patch)
2012-03-14 00:30 PDT, Jonathan Kew (:jfkthame)
jd.bugzilla: review+
Details | Diff | Splinter Review

Description Scott Johnson (:jwir3) 2012-03-13 13:19:56 PDT
The aText parameter in this function:
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxFont.cpp#4040

Is unused in the body of the function, and should probably be removed.
Comment 1 Jonathan Kew (:jfkthame) 2012-03-13 13:22:28 PDT
Yup, it can go - thanks for catching that. It was made redundant by bug 703100, but I forgot to remove it there.
Comment 2 Jonathan Kew (:jfkthame) 2012-03-14 00:30:08 PDT
Created attachment 605669 [details] [diff] [review]
eliminate unused parameter in the gfxTextRun constructor
Comment 4 Marco Bonardo [::mak] 2012-03-16 05:55:12 PDT
https://hg.mozilla.org/mozilla-central/rev/507417303ad2

Note You need to log in before you can comment on or make changes to this bug.