B2G 3G: Simplify data call handling in ril_worker.js

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

Trunk
mozilla14
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The current data call handling code was written when we didn't yet have a generic way of passing around the "options" object between RIL requests and responses. We do have that now, so we should convert it to use that.
Created attachment 605573 [details] [diff] [review]
v1
Attachment #605573 - Flags: review?(kyle)
Created attachment 605678 [details] [diff] [review]
v2

Wtf, the first patch had some accidental file removal in it. I don't even know how I managed to do that. I'm simply going to blame Mercurial for this, as usual. Here's fixed version, also with some minor improvements that I discovered between then and now.
Attachment #605573 - Attachment is obsolete: true
Attachment #605678 - Flags: review?(kyle)
Attachment #605573 - Flags: review?(kyle)
Attachment #605678 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/2892ef58d7f5
OS: Linux → Gonk
Hardware: x86_64 → ARM
Target Milestone: --- → mozilla14
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.