Closed Bug 735492 Opened 13 years ago Closed 12 years ago

B2G 3G: Simplify data call handling in ril_worker.js

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file, 1 obsolete file)

The current data call handling code was written when we didn't yet have a generic way of passing around the "options" object between RIL requests and responses. We do have that now, so we should convert it to use that.
Attached patch v1 (obsolete) — Splinter Review
Attachment #605573 - Flags: review?(kyle)
Attached patch v2Splinter Review
Wtf, the first patch had some accidental file removal in it. I don't even know how I managed to do that. I'm simply going to blame Mercurial for this, as usual. Here's fixed version, also with some minor improvements that I discovered between then and now.
Attachment #605573 - Attachment is obsolete: true
Attachment #605678 - Flags: review?(kyle)
Attachment #605573 - Flags: review?(kyle)
Attachment #605678 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/2892ef58d7f5
OS: Linux → Gonk
Hardware: x86_64 → ARM
Target Milestone: --- → mozilla14
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: