Last Comment Bug 735519 - Fix a bunch of "inlined function used but not defined" warnings
: Fix a bunch of "inlined function used but not defined" warnings
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla14
Assigned To: Steve Fink [:sfink] [:s:]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-13 16:40 PDT by Steve Fink [:sfink] [:s:]
Modified: 2012-03-16 05:53 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix a bunch of "inlined function used but not defined" warnings (2.96 KB, patch)
2012-03-13 16:40 PDT, Steve Fink [:sfink] [:s:]
dmandelin: review+
Details | Diff | Review

Description Steve Fink [:sfink] [:s:] 2012-03-13 16:40:10 PDT
I wish I had a simpler way of tracking these buggers down.
Comment 1 Steve Fink [:sfink] [:s:] 2012-03-13 16:40:17 PDT
Created attachment 605595 [details] [diff] [review]
Fix a bunch of "inlined function used but not defined" warnings
Comment 2 Brian Hackett (:bhackett) 2012-03-13 16:42:10 PDT
One trick is to change the signature of the inline function's declaration, and compile the file giving those warnings.  gdb at least should then give a not-useless error message pointing to the call it found.
Comment 3 Steve Fink [:sfink] [:s:] 2012-03-13 16:46:34 PDT
Ooh, that sounds much nicer than what I was doing!

I would compile without -j to see what .cpp generated the warning, then delete everything in that file but the #includes, then binary search through those (expanding them inline into the file when I found one, and recursing). And even then it was sometimes totally cryptic why a particular header would trigger the warnings.
Comment 4 Marco Bonardo [::mak] 2012-03-16 05:53:51 PDT
https://hg.mozilla.org/mozilla-central/rev/0c65a492f739

Note You need to log in before you can comment on or make changes to this bug.