Fix a bunch of "inlined function used but not defined" warnings

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I wish I had a simpler way of tracking these buggers down.
(Assignee)

Comment 1

5 years ago
Created attachment 605595 [details] [diff] [review]
Fix a bunch of "inlined function used but not defined" warnings
Attachment #605595 - Flags: review?(dmandelin)
One trick is to change the signature of the inline function's declaration, and compile the file giving those warnings.  gdb at least should then give a not-useless error message pointing to the call it found.
(Assignee)

Comment 3

5 years ago
Ooh, that sounds much nicer than what I was doing!

I would compile without -j to see what .cpp generated the warning, then delete everything in that file but the #includes, then binary search through those (expanding them inline into the file when I found one, and recursing). And even then it was sometimes totally cryptic why a particular header would trigger the warnings.
Attachment #605595 - Flags: review?(dmandelin) → review+
https://hg.mozilla.org/mozilla-central/rev/0c65a492f739
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.