73552 - compare methods not working on Attr nodes

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect, P5)

Description

[Jeff Yates]

I have found that ALL of the compare methods of the range object fail if the
range commonAncestorContainer is an Attr Node.

The methods effected are:
    compareBoundaryPoints
    intersectsNode
    comparePoint
    isPointInRange
    compareNode  -  This is the only one that throws an exception

I have wrote up a test case and am attaching it.

Jeff Yates

Comment 1

[Jeff Yates]

Attachment: Test case - read the source to understand it

Comment 2

[lchiang]

thanks for the testcase!

Comment 3

[Jeff Yates]

I believe that I have found the cause of this bug.  All child nodes of an Attr 
node have there parentNode property set to null.  See bug #73681.

If someone could confirm that this is what is causing this problem I will mark 
it as a dependancy/blocker.

Jeff Yates.

Comment 4

[rubydoo123]

I would suspect that this cannot get resolved at all until 73681 is resolved

Comment 5

[anthonyd]

setting to 0.9.2
anthonyd

Comment 6

[anthonyd]

getting range spec up to snuff.
setting to 0.9.3

anthonyd

Comment 7

[anthonyd]

range stuff will at somepoint have to be corrected.  i can see how people who 
wish to embed our product will need some of the range functionality to 
manipulate nodes (specifically text nodes).

anthonyd

Comment 8

[rubydoo123]

--> kin

Comment 9

[kinmoz]

Bulk move of mozilla1.0 bugs to mozilla.1.0.1. I will try to pull some of these
back in if I can.

Comment 10

[Alex Vincent [:WeirdAl]]

Testcase as posted fails to execute due to Range.intersectsNode not being implemented - this is bug 579638.

qawanted:  We should convert this into a mochitest.

Comment 11

[Ioana (away)]

Windows 2000 support has been dropped a while ago. Please only reopen this bug if you can reproduce it on Windows XP or older with current Firefox builds.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Ioana, there appears to be nothing win2k-specific about this bug.  Please don't resolve bugs as wontfix based on their (bogus, automatically set by Bugzilla) OS field without actually trying to reproduce them.

Comment 13

[Ioana (away)]

I tried to reproduce this issue with the attached test case on Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20100101 Firefox/25.0 and got the following:

* range.compareNote throws an exception (no errors, more details displayed in the Browser console).
* for range.intersectsNode, range.comparePoint, range.isPointInRange and range2.selectNodeContents, I get that "Argument 1 is not an object". The first argument for them is range.startContainer.firstChild.

I don't get any other errors. Any ideas about how I could fix this test case?

Comment 14

[Firefox Bug Husbandry Bot]

Bulk priority change, per :mdaly

Comment 15

[Anne (:annevk)]

As per bug 73681 (and the DOM Standard) Attr nodes cannot contain child nodes so the test is (now) invalid.