Created attachment 605620 [details]
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120215223356
Steps to reproduce:
When the function is called, the results that are parsed cause a syntax error. As a result of this error, a logout command is sent to the imap server, so I loose my idle connection and the next command is slow because Thunderbird has to log back in to the server.
As far as I can tell, there is not a syntax error in the response from the server, so the function should complete successfully.
Also, sending the logout command on a syntax error is debatable.
Created attachment 605621 [details]
tail of imap log file
To reproduce the error, you will need a gmail imap account setup in Thunderbird. There are lots of instructions available on how to do this, so I won't spend time writing it here.
1. Run Thunderbird with imap logging enabled. See: https://wiki.mozilla.org/MailNews:Logging#Generating_a_Protocol_Log
2. Open a gmail message.
4. A message box should show with the results of the call. It shows successful.
4. Open your imap.log file. You should see the syntax error and logout command just like the attached file.
Did you try with the latest thunderbird nightly build?
just tried it with
and got the same results.
Created attachment 609596 [details] [diff] [review]
I found a break statement in a while loop that I don't think should be there.
I probably should have mentioned that I actually compiled Thunderbird with the patch and verified that it fixed the problem.
Is there anything else I need to be doing to help move this along? Perhaps this is wishful thinking, but I was hoping that this could be included in the next release (TB12) so that I can continue development on an extension.
(In reply to David Lechner from comment #7)
> Is there anything else I need to be doing to help move this along? Perhaps
> this is wishful thinking, but I was hoping that this could be included in
> the next release (TB12) so that I can continue development on an extension.
Tests would help, though I'm not the right person to talk to about that, since my knowledge of Thunderbird's network code is slim to none.
There are no tests that call the nsIMsgImapMailFolder.fetchCustomMsgAttribute function. Does that mean I need to write one?
Comment on attachment 609596 [details] [diff] [review]
[Approval Request Comment]
thx for the patch, sorry it took a while to get to it. I don't think we're going to take this for beta since we're going to ship in a week, but I'd consider it for alpha, which will go into beta in a week.
fixed on trunk - http://hg.mozilla.org/comm-central/rev/dadbf9ddbab3
Checked in: http://hg.mozilla.org/releases/comm-aurora/rev/3ac782de680a