The default bug view has changed. See this FAQ.

fetchCustomMsgAttribute causes logoff

RESOLVED FIXED in Thunderbird 14.0

Status

MailNews Core
Networking: IMAP
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dlech, Assigned: dlech)

Tracking

({imap-interop, testcase})

Trunk
Thunderbird 14.0
imap-interop, testcase

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 605620 [details]
fetchCutomMsgAttribute_test.js

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120215223356

Steps to reproduce:

I am trying to use the nsIMsgImapMailFolder.fetchCustomMsgAttribute function in javascript to get the X-GM-LABELS attribute for a message from Gmail via imap. See attached .js file.


Actual results:

When the function is called, the results that are parsed cause a syntax error. As a result of this error, a logout command is sent to the imap server, so I loose my idle connection and the next command is slow because Thunderbird has to log back in to the server.


Expected results:

As far as I can tell, there is not a syntax error in the response from the server, so the function should complete successfully.

Also, sending the logout command on a syntax error is debatable.
(Assignee)

Comment 1

5 years ago
Created attachment 605621 [details]
tail of imap log file
(Assignee)

Comment 2

5 years ago
To reproduce the error, you will need a gmail imap account setup in Thunderbird. There are lots of instructions available on how to do this, so I won't spend time writing it here.

You will also need the Extension Developers Extension or another way to inject javascript into XUL.

1. Run Thunderbird with imap logging enabled. See: https://wiki.mozilla.org/MailNews:Logging#Generating_a_Protocol_Log
2. Open a gmail message.
3. Run the attached .js file. Using the Extension Developer's Extension: Tools > Extension Developer > JavaScript Injector, browse for the selected file, select chrome://messenger/content/messenger.xul and click "Execute!"
4. A message box should show with the results of the call. It shows successful.
4. Open your imap.log file. You should see the syntax error and logout command just like the attached file.
Keywords: imap-interop

Updated

5 years ago
Attachment #605620 - Attachment mime type: application/octet-stream → text/javascript

Comment 3

5 years ago
Did you try with the latest thunderbird nightly build?
Component: General → Networking: IMAP
Keywords: testcase
Product: Thunderbird → MailNews Core
QA Contact: general → networking.imap
(Assignee)

Comment 4

5 years ago
just tried it with

20120314030025
http://hg.mozilla.org/mozilla-central/rev/c71845b3b2a6
http://hg.mozilla.org/comm-central/rev/1593bfcee4fb

and got the same results.
(Assignee)

Comment 5

5 years ago
Created attachment 609596 [details] [diff] [review]
proposed patch

I found a break statement in a while loop that I don't think should be there.

Updated

5 years ago
Attachment #609596 - Flags: review?(dbienvenu)
(Assignee)

Comment 6

5 years ago
I probably should have mentioned that I actually compiled Thunderbird with the patch and verified that it fixed the problem.
Assignee: nobody → gismho+mozbug
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 7

5 years ago
Is there anything else I need to be doing to help move this along? Perhaps this is wishful thinking, but I was hoping that this could be included in the next release (TB12) so that I can continue development on an extension.

Comment 8

5 years ago
(In reply to David Lechner from comment #7)
> Is there anything else I need to be doing to help move this along? Perhaps
> this is wishful thinking, but I was hoping that this could be included in
> the next release (TB12) so that I can continue development on an extension.

Tests would help, though I'm not the right person to talk to about that, since my knowledge of Thunderbird's network code is slim to none.
(Assignee)

Comment 9

5 years ago
There are no tests that call the nsIMsgImapMailFolder.fetchCustomMsgAttribute function. Does that mean I need to write one?

Comment 10

5 years ago
Comment on attachment 609596 [details] [diff] [review]
proposed patch

[Approval Request Comment]

thx for the patch, sorry it took a while to get to it. I don't think we're going to take this for beta since we're going to ship in a week, but I'd consider it for alpha, which will go into beta in a week.
Attachment #609596 - Flags: review?(dbienvenu)
Attachment #609596 - Flags: review+
Attachment #609596 - Flags: approval-comm-aurora?

Comment 11

5 years ago
fixed on trunk - http://hg.mozilla.org/comm-central/rev/dadbf9ddbab3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Version: 10 → Trunk

Updated

5 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Attachment #609596 - Flags: approval-comm-aurora? → approval-comm-aurora+
Checked in: http://hg.mozilla.org/releases/comm-aurora/rev/3ac782de680a
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.