Last Comment Bug 735581 - B2G RIL MSISDN follow-ups
: B2G RIL MSISDN follow-ups
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
-- normal (vote)
: mozilla14
Assigned To: Philipp von Weitershausen [:philikon]
: Andrew Overholt [:overholt]
Depends on:
Blocks: 720638
  Show dependency treegraph
Reported: 2012-03-14 00:06 PDT by Philipp von Weitershausen [:philikon]
Modified: 2012-03-15 18:04 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1 (2.17 KB, patch)
2012-03-14 00:08 PDT, Philipp von Weitershausen [:philikon]
no flags Details | Diff | Splinter Review
v2 (4.79 KB, patch)
2012-03-14 01:24 PDT, Philipp von Weitershausen [:philikon]
kyle: review+
Details | Diff | Splinter Review

Description User image Philipp von Weitershausen [:philikon] 2012-03-14 00:06:35 PDT
I said that I addressed the nits in the patch for bug 720638, but I apparently missed a few. Probably forgot a qrefresh?
Comment 1 User image Philipp von Weitershausen [:philikon] 2012-03-14 00:08:25 PDT
Created attachment 605667 [details] [diff] [review]

Anywhere, here they are. Cf. bug 720638 comment 27 and comment 29
Comment 2 User image Philipp von Weitershausen [:philikon] 2012-03-14 01:24:14 PDT
Created attachment 605680 [details] [diff] [review]

Found another small nit that I thought I'd address in this bug: moving the RIL.iccIO() method out from among all datacall related methods and next to ICC related methods.
Comment 3 User image Philipp von Weitershausen [:philikon] 2012-03-15 18:04:08 PDT

Note You need to log in before you can comment on or make changes to this bug.