B2G RIL MSISDN follow-ups

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

Trunk
mozilla14
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I said that I addressed the nits in the patch for bug 720638, but I apparently missed a few. Probably forgot a qrefresh?
(Assignee)

Updated

5 years ago
Blocks: 720638
Created attachment 605667 [details] [diff] [review]
v1

Anywhere, here they are. Cf. bug 720638 comment 27 and comment 29
Attachment #605667 - Flags: review?(kyle)
Created attachment 605680 [details] [diff] [review]
v2

Found another small nit that I thought I'd address in this bug: moving the RIL.iccIO() method out from among all datacall related methods and next to ICC related methods.
Attachment #605667 - Attachment is obsolete: true
Attachment #605667 - Flags: review?(kyle)
Attachment #605680 - Flags: review?(kyle)
Attachment #605680 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/9499b0bcce74
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.