Closed Bug 735581 Opened 12 years ago Closed 12 years ago

B2G RIL MSISDN follow-ups

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file, 1 obsolete file)

v2
4.79 KB, patch
qdot
: review+
Details | Diff | Splinter Review 
I said that I addressed the nits in the patch for bug 720638, but I apparently missed a few. Probably forgot a qrefresh?
Blocks: 720638
Attached patch v1 (obsolete) — — Splinter Review 
Anywhere, here they are. Cf. bug 720638 comment 27 and comment 29
Attachment #605667 - Flags: review?(kyle)
Attached patch v2 — — Splinter Review 
Found another small nit that I thought I'd address in this bug: moving the RIL.iccIO() method out from among all datacall related methods and next to ICC related methods.
Attachment #605667 - Attachment is obsolete: true
Attachment #605667 - Flags: review?(kyle)
Attachment #605680 - Flags: review?(kyle)
Attachment #605680 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/9499b0bcce74
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: