735612 - MAPLE: Zoomed-in page is not displayed after changing the device orientation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Attachment: Screenshot

Nightly Maple (2012-03-13)
Device: HTC Desire Z
OS: Android 2.3.3

Steps:
1. Open Nightly Maple.
2. Load news.google.com desktop version.
3. Zoom in the page at max level.
4. Rotate the device in landscape mode. 

Expected: 
The page should be properly displayed

Actual: 
The page is not displayed. The screen displays the attached image.

Comment 1

[Paul Feher]

Attachment: Log file

Comment 2

[Aaron Train [:aaronmt]]

Kats, this sounds like a duplicate.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

It does, but I'm not sure what it's a dupe of. Also the log looks normal and I wasn't able to repro on a GN with ICS. Will try a desire Z if I can find one.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I'm able to reproduce this on the HTC, and I'm pretty sure I know why it's happening (we're not updating Gecko's viewport after we clamp down the zoom in Java because the display port is still considered valid). I can think of a quick fix but I'd rather think about it some more first to make sure it's the best fix.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Put back missing synchronization

The viewport was being modified from the UI thread without the necessary synchronization and this was interfering with the display port calculations.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Remove unnecessary notifyLayerClient call

Changeset 18fa9efab290 put back the notifyLayerClientOfGeometryChange call at the end of PanZoomController.abortAnimation, so we don't need to call it again.

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 605976 [details] [diff] [review]
(1/2) Put back missing synchronization

Review of attachment 605976 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 605978 [details] [diff] [review]
(2/2) Remove unnecessary notifyLayerClient call

Review of attachment 605978 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d001070ab8c8
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0dbd91f956f

Comment 10

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d001070ab8c8
https://hg.mozilla.org/mozilla-central/rev/d0dbd91f956f

Comment 11

[Paul Feher]

Verified/fixed on:
 
Nightly Fennec/14.0a1 (2012-03-22)
Device: HTC Desire - Android 2.2.2
Motorola Droid 2 - Android 2.3.3