735663 - crash nsCaretAccessible::SetControlSelectionListener

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

This bug was filed from the Socorro interface and is 
report bp-9e090e1f-dd94-411f-a45f-76f002120310 .
============================================================= 

Reported to me by a community member using JAWS.

Comment 1

[Scoobidiver (away)]

It's a low volume crash with some crashes on 10.0.2:
https://crash-stats.mozilla.com/report/list?signature=nsCaretAccessible%3A%3ASetControlSelectionListener%28nsIContent*%29

Comment 2

[alexander :surkov (:asurkov)]

Jim, it sounds like the problem is when window is closed, JAWS is notified about that and does something that sends WM_ACTIVE event so that makes Gecko to fire DOM focus event which is handled by accessibility again. Can you think of the way to prevent things like this, i.e. do not respond to WM_ACTIVATE and maybe some other events when window is destroyed.

Comment 3

[alexander :surkov (:asurkov)]

It sounds I forgot to cc Jim

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Looking at Socorro it seems this happens very rarely. In different stacks I noticed Jaws 11 and Jaws 12 in use.

Seems like we fail with a null mRootAccessible

nsCaretAccessible::SetControlSelectionListener(nsIContent *aCurrentNode)
{
  NS_ENSURE_TRUE(mRootAccessible, NS_ERROR_FAILURE);

Possibly related to our general tree updating pain.

Comment 5

[Jim Mathies [:jimm]]

(In reply to alexander :surkov from comment #2)
> Jim, it sounds like the problem is when window is closed, JAWS is notified
> about that and does something that sends WM_ACTIVE event so that makes Gecko
> to fire DOM focus event which is handled by accessibility again. Can you
> think of the way to prevent things like this, i.e. do not respond to
> WM_ACTIVATE and maybe some other events when window is destroyed.

Is the widget object still around? If so we have flags in widget - mInDtor and mDestroyCalled that could be used to prevent sending certain events.

Comment 6

[alexander :surkov (:asurkov)]

this one was fixed by bug 678477 (rootAccessible doesn't take longer any participation in caret management)