RotateLeft32 conflicts with winnt.h macro

RESOLVED FIXED in mozilla14

Status

()

Core
MFBT
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla14
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 605780 [details] [diff] [review]
fix v1.0

It seems to be undocumented, but winnt.h contains macro which defines RotateLeft32 to _rotl. It's a macro, so mozilla namespace doesn't help and if winnt.h is included before HashFunctions.h, it gets replaced. It does not yet cause compilation errors on MSVC (it does on mingw), but it's surely something we should avoid. My proposed patch renames the function to RotateBitsLeft32.
Attachment #605780 - Flags: review?(jwalden+bmo)
Attachment #605780 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 1

5 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/61447dccb529
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/61447dccb529
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.