Closed Bug 735704 Opened 8 years ago Closed 8 years ago

RotateLeft32 conflicts with winnt.h macro

Categories

(Core :: MFBT, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
It seems to be undocumented, but winnt.h contains macro which defines RotateLeft32 to _rotl. It's a macro, so mozilla namespace doesn't help and if winnt.h is included before HashFunctions.h, it gets replaced. It does not yet cause compilation errors on MSVC (it does on mingw), but it's surely something we should avoid. My proposed patch renames the function to RotateBitsLeft32.
Attachment #605780 - Flags: review?(jwalden+bmo)
Attachment #605780 - Flags: review?(jwalden+bmo) → review+
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/61447dccb529
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/61447dccb529
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.