735740 - Add a way to delete individual form entries.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Tracy Walker [:tracy]]

On desktop, we have alt+shift+delete when a form entry item is highlighted.  

In irc, Madhava suggested some sort of long tap menu item

Comment 1

[Christian Ascheberg]

It would be really helpful if there was a possibility to delete individual form entries.

For example, there is a route planer that I regularly use:
1. It is easy to mistype the current address and then accidentally submit the form.
2. There are only a few addresses that I use more than once.
So all the other entries just make it harder to select the correct/relevant ones.

A quick suggestion for UI:
If you long tap the form you already get options such as pasting and input method. Add an option to manage entries. After choosing that, list all the available entries with a checkbox and one delete button on the bottom.

Comment 2

[Brian Nicholson (:bnicholson)]

This would still be nice to have. In addition to the regular OnItemClickListener at [1], we should be able to attach an OnItemLongClickListener to show a remove dialog. From there, we'll need to send a message back to Gecko to actually handle the removal since Gecko owns the autocomplete DB.

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/FormAssistPopup.java?rev=e0c877dfa4da#152

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: formfill-remove v0.1

This patch allows people to remove items from the Form AutoFill list using a long-tap. Much like Desktop, which uses a <DEL> keypress, there is no confirmation request.

We send a JSON message to Gecko to handle the DB removal, but update the list in Java. This seems to work OK and updates the position of the list if it happened to be in an edge-case.

If we find this is not working well enough, we can ask Gecko to handle the update, but I was hoping to avoid more JSON messaging if possible.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8490700 [details] [diff] [review]
formfill-remove v0.1

Review of attachment 8490700 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though the long tap being used as the DEL key is strange...I haven't seen us (or even other apps) use "long tap to delete" before. The lib in bug 1030896 should allow us to easily attach swipe-to-dismiss to ViewGroups, so maybe that'll be something to consider once it lands.

Comment 5

[Brian Nicholson (:bnicholson)]

(In reply to Brian Nicholson (:bnicholson) from comment #4)
> The lib in bug 1030896 should allow us to easily attach swipe-to-dismiss
> to ViewGroups, so maybe that'll be something to consider once it lands.

Setting bug 1030896 as a blocker since it sounds like we want this.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: formfill-remove v0.2

LOL! This was easy to change to use "swipe to remove". I kept the comment (since this is still a listview) and the scroll and recycle listeners from the Search activity bug.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/227e7d0e0b69

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/227e7d0e0b69

Comment 9

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in latest builds:
Firefox for Android 37.0a1 (2014-12-09)
Firefox for Android 36.0a2 (2014-12-09)
Firefox for Android 35.b1

Device: Nexus 4 (Android 4.4.4)