Closed Bug 735761 Opened 13 years ago Closed 13 years ago

Fix double-printing of progress bar in jsreftest suite

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: terrence, Assigned: terrence)

Details

Attachments

(1 file)

The jsreftest unixification appears to have resulted in us printing \nPASS\n before calling pb.done(). This results in the progressbar getting printed in front of the next command prompt.
Attached patch v0Splinter Review
I was pushing the list of non-run tests to the results list (for completeness sake), but I was doing it after we finished the progress bar. This pushes them first so that we don't print them as progress after we are already finished.
Assignee: general → terrence
Status: NEW → ASSIGNED
Attachment #607818 - Flags: review?(dmandelin)
Attachment #607818 - Flags: review?(dmandelin) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: