Last Comment Bug 735761 - Fix double-printing of progress bar in jsreftest suite
: Fix double-printing of progress bar in jsreftest suite
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Terrence Cole [:terrence]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-14 10:48 PDT by Terrence Cole [:terrence]
Modified: 2012-03-22 06:30 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v0 (1.16 KB, patch)
2012-03-20 18:25 PDT, Terrence Cole [:terrence]
dmandelin: review+
Details | Diff | Splinter Review

Description Terrence Cole [:terrence] 2012-03-14 10:48:39 PDT
The jsreftest unixification appears to have resulted in us printing \nPASS\n before calling pb.done().  This results in the progressbar getting printed in front of the next command prompt.
Comment 1 Terrence Cole [:terrence] 2012-03-20 18:25:05 PDT
Created attachment 607818 [details] [diff] [review]
v0

I was pushing the list of non-run tests to the results list (for completeness sake), but I was doing it after we finished the progress bar.  This pushes them first so that we don't print them as progress after we are already finished.
Comment 2 Terrence Cole [:terrence] 2012-03-21 11:50:43 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/2688501871d5
Comment 3 Marco Bonardo [::mak] 2012-03-22 06:30:18 PDT
https://hg.mozilla.org/mozilla-central/rev/2688501871d5

Note You need to log in before you can comment on or make changes to this bug.