The default bug view has changed. See this FAQ.

Fix double-printing of progress bar in jsreftest suite

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The jsreftest unixification appears to have resulted in us printing \nPASS\n before calling pb.done().  This results in the progressbar getting printed in front of the next command prompt.
(Assignee)

Comment 1

5 years ago
Created attachment 607818 [details] [diff] [review]
v0

I was pushing the list of non-run tests to the results list (for completeness sake), but I was doing it after we finished the progress bar.  This pushes them first so that we don't print them as progress after we are already finished.
Assignee: general → terrence
Status: NEW → ASSIGNED
Attachment #607818 - Flags: review?(dmandelin)
Attachment #607818 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2688501871d5
https://hg.mozilla.org/mozilla-central/rev/2688501871d5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.