735781 - Make sure nsScreen don't call RemoveObserver when it's actually not observing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Follow-up from bug 725951: nsScreen was causing the crash because it can call twice RemoveObserver().

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

As promised.

Comment 2

[Justin Lebar (not reading bugmail)]

Did you forget to qref?  I don't see how this changes anything -- we'll still always call UnregisterScreenOrientationObserver.

Comment 3

[Mounir Lamouri (:mounir)]

The issue was that Invalidate() was called then mScreen was set to nsnull so mScreen was finally deleted and the dtor called so Invalidate() was called again. This should fix the issue.

Comment 4

[Justin Lebar (not reading bugmail)]

Comment on attachment 605975 [details] [diff] [review]
Patch v1

Oh, duh.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/329c07609ca8

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I backed this out along with all the other patches in the initial push. Something in the push regressed Ts on Android by 20% and I don't know which patch is to blame:

https://hg.mozilla.org/mozilla-central/rev/e94edfdb1f5b

Regression Ts increase 20.6% on Android 2.2 Mozilla-Inbound
--------------------------------------------------------------
    Previous: avg 2653.656 stddev 87.856 of 30 runs up to revision 1239bd0779a6
    New     : avg 3201.178 stddev 110.202 of 5 runs since revision 0d61a0d8dba4
    Change  : +547.522 (20.6% / z=6.232)
    Graph   : http://mzl.la/zD3EWy

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d5713db68749