jit-tests broken for browser builds on mac

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

So, jit-test.py traverses through symlinks:

http://mxr.mozilla.org/mozilla-central/source/js/src/jit-test/jit_test.py#434

This breaks things on browser builds (at least on mac), because js is linked against nspr, which is symlinked into dist/bin. And while the symlinked |js| lives in dist/bin, the actual one lives in obj/js/src/shell.

Chris, can you explain what you were doing here with the realpath? I'd like to remove it, but I'm not sure if it'll break something else.
(In reply to Bobby Holley (:bholley) from comment #0)
> So, jit-test.py traverses through symlinks:
> 
> http://mxr.mozilla.org/mozilla-central/source/js/src/jit-test/jit_test.py#434
> 
> This breaks things on browser builds (at least on mac), because js is linked
> against nspr, which is symlinked into dist/bin. And while the symlinked |js|
> lives in dist/bin, the actual one lives in obj/js/src/shell.

So the linker doesn't find nspr when js is run with its real path?

> Chris, can you explain what you were doing here with the realpath? I'd like
> to remove it, but I'm not sure if it'll break something else.

Not sure. If you remove it and it works in shell and browser builds, then it should be OK. If not, someone will complain and we'll fix more.
(In reply to David Mandelin from comment #1)
> (In reply to Bobby Holley (:bholley) from comment #0)
> > So, jit-test.py traverses through symlinks:
> > 
> > http://mxr.mozilla.org/mozilla-central/source/js/src/jit-test/jit_test.py#434
> > 
> > This breaks things on browser builds (at least on mac), because js is linked
> > against nspr, which is symlinked into dist/bin. And while the symlinked |js|
> > lives in dist/bin, the actual one lives in obj/js/src/shell.
> 
> So the linker doesn't find nspr when js is run with its real path?

Right. Because the real path is build/js/src/shell, and nspr is symlinked into dist/bin.

> Not sure. If you remove it and it works in shell and browser builds, then it
> should be OK. If not, someone will complain and we'll fix more.

Ok, I've done a try push. If it works, I'll push it for real with r=dmandelin:

https://tbpl.mozilla.org/?tree=Try&rev=a0c799aefa4c
Looks green - pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/86a7d913b1be
Assignee: general → bobbyholley+bmo
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/86a7d913b1be
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.