Closed
Bug 735831
Opened 13 years ago
Closed 13 years ago
NSWorkspace's isLionOrHigher short-circuit doesn't work on SDKs < 10.6
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
References
Details
(Whiteboard: [camino-2.1.3])
Attachments
(1 file)
|
435 bytes,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
As discovered in bug 714005 comment 19-22, the MAC_OS_X_VERSION_MIN_REQUIRED-based short-circuit for isLionOrHigher introduced in bug 717476 doesn't work with the default 10.4 SDK (nor, presumably, the 10.5 SDK).
This means that everyone(!) is getting the 10.7 bookmark bar behavior right now, and also Dan's fix for bug 714005 won't work right out-of-the-box on < 10.7 systems.
This fix removes the short-circuit right now.
Attachment #605919 -
Flags: superreview?(stuart.morgan+bugzilla)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 605919 [details] [diff] [review]
Remove the short-circuit
sr=smorgan
(Alternately we could look up the value of MAC_OS_X_VERSION_10_6 and then hard-code that in a check, but this is cleaner)
Attachment #605919 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.1.3]
You need to log in
before you can comment on or make changes to this bug.
Description
•