Closed
Bug 735861
Opened 13 years ago
Closed 13 years ago
Make shared-libraries.h not build on platforms where Gecko Profiler is not supported
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
I'll also add include guards.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #605966 -
Flags: review?(bgirard)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → ehsan
|
||
Comment 2•13 years ago
|
||
Comment on attachment 605966 [details] [diff] [review]
Patch (v1)
I'm not convinced this wont break existing code that is including Telemetry.h.
http://mxr.mozilla.org/mozilla-central/search?string=shared-libraries.h
We should either return an empty set of shared library where it's not supported, or better yet not include this header on platforms where it's not supported.
Attachment #605966 -
Flags: review?(bgirard) → review-
|
|
Assignee | |
Comment 3•13 years ago
|
||
Sorry, forgot to mention, bug 735422 does that. Does that address your concern?
Depends on: 735422
|
|
Assignee | |
Updated•13 years ago
|
Attachment #605966 -
Flags: review- → review?(bgirard)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 605966 [details] [diff] [review]
Patch (v1)
yes
Attachment #605966 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Target Milestone: --- → mozilla14
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•