The default bug view has changed. See this FAQ.

Make shared-libraries.h not build on platforms where Gecko Profiler is not supported

RESOLVED FIXED in mozilla14

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla14
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I'll also add include guards.
(Assignee)

Comment 1

5 years ago
Created attachment 605966 [details] [diff] [review]
Patch (v1)
Attachment #605966 - Flags: review?(bgirard)
(Assignee)

Updated

5 years ago
Assignee: nobody → ehsan
Comment on attachment 605966 [details] [diff] [review]
Patch (v1)

I'm not convinced this wont break existing code that is including Telemetry.h.

http://mxr.mozilla.org/mozilla-central/search?string=shared-libraries.h

We should either return an empty set of shared library where it's not supported, or better yet not include this header on platforms where it's not supported.
Attachment #605966 - Flags: review?(bgirard) → review-
(Assignee)

Comment 3

5 years ago
Sorry, forgot to mention, bug 735422 does that.  Does that address your concern?
Depends on: 735422
(Assignee)

Updated

5 years ago
Attachment #605966 - Flags: review- → review?(bgirard)
Comment on attachment 605966 [details] [diff] [review]
Patch (v1)

yes
Attachment #605966 - Flags: review?(bgirard) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/29022cdb007d
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/29022cdb007d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.