Last Comment Bug 735861 - Make shared-libraries.h not build on platforms where Gecko Profiler is not supported
: Make shared-libraries.h not build on platforms where Gecko Profiler is not su...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla14
Assigned To: :Ehsan Akhgari
:
:
Mentors:
Depends on: 735422
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-14 14:38 PDT by :Ehsan Akhgari
Modified: 2012-03-15 08:26 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.26 KB, patch)
2012-03-14 14:52 PDT, :Ehsan Akhgari
b56girard: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2012-03-14 14:38:05 PDT
I'll also add include guards.
Comment 1 :Ehsan Akhgari 2012-03-14 14:52:08 PDT
Created attachment 605966 [details] [diff] [review]
Patch (v1)
Comment 2 Benoit Girard (:BenWa) 2012-03-14 15:43:47 PDT
Comment on attachment 605966 [details] [diff] [review]
Patch (v1)

I'm not convinced this wont break existing code that is including Telemetry.h.

http://mxr.mozilla.org/mozilla-central/search?string=shared-libraries.h

We should either return an empty set of shared library where it's not supported, or better yet not include this header on platforms where it's not supported.
Comment 3 :Ehsan Akhgari 2012-03-14 15:54:23 PDT
Sorry, forgot to mention, bug 735422 does that.  Does that address your concern?
Comment 4 Benoit Girard (:BenWa) 2012-03-14 16:10:19 PDT
Comment on attachment 605966 [details] [diff] [review]
Patch (v1)

yes
Comment 6 Marco Bonardo [::mak] 2012-03-15 08:26:37 PDT
https://hg.mozilla.org/mozilla-central/rev/29022cdb007d

Note You need to log in before you can comment on or make changes to this bug.