735874 - Add-on options should show/hide when add-on is enabled/disabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:

1. Install an add-on with options.
2. Open the add-on manager and tap on the add-on.
4. Disable the add-on.

Expected results: Add-on options are hidden.
Actual results: Add-on options are still visible and enabled.

5. Quit and then re-start the browser.
6. Open the add-on manager and tap on the add-on.
7. Enable the add-on.

Expected results: Add-on options are visible.
Actual results: Add-on options are still hidden.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: 1/2: refactor enable/disable methods

This patch factors out some duplicate code in the enable/disable functions.

It also fixes the code to disable the previously-active theme.  This was broken because it called "this.disable(addon)" while the disable() method does not actually take any arguments.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: 2/2: show and hide the options for enabled/disabled add-ons

We can't load options for add-ons that are disabled at startup, so we need to retry when the add-on is enabled.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 605972 [details] [diff] [review]
1/2: refactor enable/disable methods

Nice refactor

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b9a25a297c9
https://hg.mozilla.org/integration/mozilla-inbound/rev/60c732729b69

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/4b9a25a297c9
https://hg.mozilla.org/mozilla-central/rev/60c732729b69

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1feb4846ca08
https://hg.mozilla.org/releases/mozilla-aurora/rev/21ec29a1a6f9

Comment 7

[Paul Feher]

Verified/fixed on:

Aurora Fennec 13.0a2 (2012-03-27)
Nightly Fennec 14.0a1 (2012-03-27)
Device: Samsung Nexus S
OS: Android 2.3.6