Closed
Bug 735877
Opened 12 years ago
Closed 12 years ago
Update syntax hints in pref files to reflect the fact that you can't use computed values (e.g. 2 * 4)
Categories
(Core :: Preferences: Backend, defect)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
Attachments
(1 file)
2.14 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
See bug 732820 comment 24 -- using computed values (e.g. 50 * 1024) in pref files causes major bustage. We should update the "syntax hints" section at the top of the pref files to reflect this.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #605988 -
Flags: review?(dtownsend+bugmail)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → justin.lebar+bug
Comment 2•12 years ago
|
||
I'd like to know *why* computed values don't work. Is this not a vanilla JS file?
Comment 3•12 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #2) > I'd like to know *why* computed values don't work. Is this not a vanilla JS > file? The file is not executed as JS, it's just simply parsed as text
Updated•12 years ago
|
Attachment #605988 -
Flags: review?(dtownsend+bugmail) → review+
Comment 4•12 years ago
|
||
> The file is not executed as JS, it's just simply parsed as text
Ah. Maybe changing the suffix to .txt would help avoid confusion?
Comment 5•12 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #4) > > The file is not executed as JS, it's just simply parsed as text > > Ah. Maybe changing the suffix to .txt would help avoid confusion? At the expense of an awful lot of bustage. Given the few cases that I've heard of this causing problems I don't think it is worth it.
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eb8564567df
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0eb8564567df
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Comment 8•12 years ago
|
||
(In reply to Nicholas Nethercote from comment #2) > Is this not a vanilla JS file? It used to be before bug 98533 back in 2003...
You need to log in
before you can comment on or make changes to this bug.
Description
•