Closed Bug 735877 Opened 9 years ago Closed 9 years ago

Update syntax hints in pref files to reflect the fact that you can't use computed values (e.g. 2 * 4)

Categories

(Core :: Preferences: Backend, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

See bug 732820 comment 24 -- using computed values (e.g. 50 * 1024) in pref files causes major bustage.

We should update the "syntax hints" section at the top of the pref files to reflect this.
Attached patch Patch v1Splinter Review
Attachment #605988 - Flags: review?(dtownsend+bugmail)
Assignee: nobody → justin.lebar+bug
I'd like to know *why* computed values don't work.  Is this not a vanilla JS file?
(In reply to Nicholas Nethercote [:njn] from comment #2)
> I'd like to know *why* computed values don't work.  Is this not a vanilla JS
> file?

The file is not executed as JS, it's just simply parsed as text
Attachment #605988 - Flags: review?(dtownsend+bugmail) → review+
> The file is not executed as JS, it's just simply parsed as text

Ah.  Maybe changing the suffix to .txt would help avoid confusion?
(In reply to Nicholas Nethercote [:njn] from comment #4)
> > The file is not executed as JS, it's just simply parsed as text
> 
> Ah.  Maybe changing the suffix to .txt would help avoid confusion?

At the expense of an awful lot of bustage. Given the few cases that I've heard of this causing problems I don't think it is worth it.
https://hg.mozilla.org/mozilla-central/rev/0eb8564567df
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
(In reply to Nicholas Nethercote from comment #2)
> Is this not a vanilla JS file?

It used to be before bug 98533 back in 2003...
You need to log in before you can comment on or make changes to this bug.