735936 - "Assertion failure: !(flags & (0x40 | 0x80)),"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

f = (function() {
    "use strict";
    [arguments] = eval()
})

asserts js debug shell on m-c changeset 7e713db43d8d without any CLI arguments at Assertion failure: !(flags & (0x40 | 0x80)),

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   87904:bd71047c9b4d
user:        Luke Wagner
date:        Tue Feb 07 12:34:29 2012 -0800
summary:     Bug 724790 - get rid of the hasOverriddenArgs funny business (r=waldo)

Comment 1

[Luke Wagner [:luke]]

The bug here predates bug 724790, bug 724790 just added an assert (at Waldo's suggestion) that caught it.  Waldo: seems like destructuring needs to check for a strict-mode error?

Comment 2

[Luke Wagner [:luke]]

Also, why in the world is the destructoring code emitting qnamepart/enumelem...

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Seems fixed by bug 740446.

autoBisect shows this is probably related to the following changeset:

The first good revision is:
changeset:   91358:fa24b215d49e
user:        Luke Wagner
date:        Mon Apr 02 08:58:30 2012 -0700
summary:     Bug 740446 - make 'arguments' more like a normal local binding (r=bhackett)

Comment 4

[Jeff Walden [:Waldo]]

Yeah, the destructuring code appears to need strict mode error handling.  :-\  Filed bug 757273 on that.

Comment 5

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929