735944 - about:support says "incremental gc: 1" when javascript.options.mem.gc_incremental is disabled

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Set javascript.options.mem.gc_incremental to false (this is the default in recent nightly builds).
2. Open about:support and scroll to the bottom.

Actual results: "Incremental GC: 1" meaning that incremental GC is enabled.

Expected results: "1" is confusing here because incremental GC is not actually running.  Perhaps it should say "0" in this case, or perhaps some other value to indicate that it is disabled by preference.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 622524 [details] [diff] [review]
patch

Review of attachment 622524 [details] [diff] [review]:
-----------------------------------------------------------------

The state space here is getting rather large.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/340ceeb73757

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/340ceeb73757

Comment 5

[Ioana (away)]

Verified as fixed on Firefox Aurora(20120609042006) and Nightly(20120611030526).