735968 - PlacesUtils.history must be QI-ed before using nsPIPlacesDatabase methods

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Bobby Holley (:bholley)]

We were getting lucky before compartment-per-global, but now it's broken. The lazy getter only QIs to nsINavHistoryService:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/PlacesUtils.jsm#2205

Attaching a patch. Flagging philikon for review.

Is there anywhere where this might crop up in non-test code? We _could_ always make the service getter non-lazy and explicitly QI it, but that seems ugly.

Comment 1

[Bobby Holley (:bholley)]

Attachment: patch. v1

Comment 2

[Bobby Holley (:bholley)]

(FWIW this is time-sensitive, so please let me know right away if I guessed the wrong reviewer).

Comment 3

[Richard Newman [:rnewman]]

The module code itself does the right thing:

modules/engines/history.js
112:    let db = PlacesUtils.history.QueryInterface(Ci.nsPIPlacesDatabase)

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 606080 [details] [diff] [review]
patch. v1

Review of attachment 606080 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK to me.

Comment 5

[Bobby Holley (:bholley)]

Pushed to m-i:

http://hg.mozilla.org/integration/mozilla-inbound/rev/39da111adaf5

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/39da111adaf5