Closed
Bug 735986
Opened 13 years ago
Closed 13 years ago
Remove spellCheckAddToDictionary.label/accesskey from DTD file.
Categories
(SeaMonkey :: MailNews: Composition, defect)
SeaMonkey
MailNews: Composition
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.11
People
(Reporter: ewong, Assigned: pranavrc)
Details
(Whiteboard: [good first bug][mentor=IanN][lang=xul])
Attachments
(1 file, 1 obsolete file)
|
2.63 KB,
patch
|
iannbugzilla
:
review+
standard8
:
review+
|
Details | Diff | Splinter Review |
Bug #655529 removed the spellCheckAddToDictionary from usage. So the
dtd entries can be safely removed.
http://mxr.mozilla.org/comm-central/search?string=spellCheckAddToDictionary&find=suite%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
|
Reporter | |
Updated•13 years ago
|
OS: Windows Vista → All
Hardware: x86 → All
Whiteboard: [good first bug][mentor=IanN][lang=xul]
Version: SeaMonkey 2.8 Branch → Trunk
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → prp.1111
Status: NEW → ASSIGNED
Attachment #609784 -
Flags: review?(iann_bugzilla)
Comment on attachment 609784 [details] [diff] [review]
proposed patch
You will also find, I think, that spellCheckNoSuggestions.label and spellCheckIgnoreWord.label/accesskey can be removed from this file.
Also all those 5 entities can probably be removed from editorOverlay.dtd too.
r- as I would like to see the new patch.
Attachment #609784 -
Flags: review?(iann_bugzilla) → review-
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #609784 -
Attachment is obsolete: true
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 611267 [details] [diff] [review]
Proposed patch v2
Pranav, did you intend to ask for review for this patch?
Attachment #611267 -
Attachment description: Proposed patch → Proposed patch v2
Attachment #611267 -
Flags: review?(iann_bugzilla)
Comment on attachment 611267 [details] [diff] [review]
Proposed patch v2
You will also need a review from Standard8 for the changes in editor.
Attachment #611267 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
@Philip - I did, sorry about that.
@Ian - Thanks for the review, I'll request a review from standard8.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #611267 -
Flags: review?(mbanner)
|
||
Comment 7•13 years ago
|
||
Comment on attachment 611267 [details] [diff] [review]
Proposed patch v2
Looks good, sorry for the delay.
Attachment #611267 -
Flags: review?(mbanner) → review+
|
|
||
Comment 8•13 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/b6bb17ff4973
Thank you Pranav for your patch.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.11
You need to log in
before you can comment on or make changes to this bug.
Description
•