B2G Wifi: Fire notification for signal strength changes

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
We need this to put the relative signal strength in the title bar.
(Assignee)

Comment 1

5 years ago
Created attachment 607001 [details] [diff] [review]
Patch v.5

Still to do here:

- Add an API so that you don't have to wait for an event to update the status (mozWifiManager.connectionInfo, perhaps?).
- Suppress the event if nothing changed.
Attachment #607001 - Flags: feedback?(kaze)
(Assignee)

Comment 2

5 years ago
Created attachment 607150 [details] [diff] [review]
Patch v1

There is now a .connectionInformation property as well as the event. I also avoid sending the event if the signal strength hasn't changed more than 10% since the last time we checked.
Attachment #607001 - Attachment is obsolete: true
Attachment #607001 - Flags: feedback?(kaze)
Attachment #607150 - Flags: review?(gal)
Attachment #607150 - Flags: feedback?(kaze)
(Assignee)

Comment 3

5 years ago
Oh, please pretend that this was applied in the previous diff:

diff --git a/dom/wifi/nsIWifi.idl b/dom/wifi/nsIWifi.idl
index 8063aac..f06565d 100644
--- a/dom/wifi/nsIWifi.idl
+++ b/dom/wifi/nsIWifi.idl
@@ -43,7 +43,7 @@
 interface nsIWifi : nsISupports {
 };
 
-[scriptable, uuid(1509221f-470e-4445-b476-88e74fd5c617)]
+[scriptable, uuid(bdc74103-85e7-4e6a-bf68-55fc35b7ad2f)]
 interface nsIDOMWifiManager : nsISupports {
     /**
      * TODO Remove in favor of a settings API.
(Assignee)

Comment 4

5 years ago
Comment on attachment 607150 [details] [diff] [review]
Patch v1

If this is needed for 2.5, it needs review. Chris might have a little more time at this point than gal.
Attachment #607150 - Flags: review?(jones.chris.g)
Attachment #607150 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 609350 [details] [diff] [review]
Rebased

This is rebased and fixes a couple of dumb bugs in DOMWifiManager.js (notably where I'd switched from this._onConnection... to this._connection...).
Attachment #607150 - Attachment is obsolete: true
Attachment #607150 - Flags: review?(gal)
Attachment #607150 - Flags: feedback?(kaze)
Attachment #609350 - Flags: review+
Attachment #609350 - Flags: feedback?(kaze)
Blocks: 717123
OS: Linux → Gonk
Hardware: x86_64 → ARM
Summary: Wifi: Fire notification for signal strength changes → B2G Wifi: Fire notification for signal strength changes
(Assignee)

Comment 6

5 years ago
(slightly tweaked to fix even more typos) https://hg.mozilla.org/mozilla-central/rev/7f4d6e62d1f7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
(Assignee)

Updated

5 years ago
Attachment #609350 - Flags: feedback?(kaze)
You need to log in before you can comment on or make changes to this bug.