736125 - More Java (1.7) related warnings causing errors on build

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

/home/aaronmt/Mozilla/Mozilla-Central/mobile/android/base/GeckoApp.java:1324: warning: [static] static variable should be qualified by type name, Tab, instead of by an expression
                if (tab.getState() != tab.STATE_LOADING) {
                                         ^
error: warnings found and -Werror specified
/home/aaronmt/Mozilla/Mozilla-Central/mobile/android/base/gfx/LayerController.java:145: warning: [static] static method should be qualified by type name, Tabs, instead of by an expression
        Tabs.getInstance().registerOnTabsChangedListener(this);
                          ^
/home/aaronmt/Mozilla/Mozilla-Central/mobile/android/base/gfx/LayerController.java:148: warning: [static] static method should be qualified by type name, ViewConfiguration, instead of by an expression
        mTimeout = vc.getLongPressTimeout();
                     ^
/home/aaronmt/Mozilla/Mozilla-Central/mobile/android/base/gfx/LayerController.java:152: warning: [static] static method should be qualified by type name, Tabs, instead of by an expression
        Tabs.getInstance().unregisterOnTabsChangedListener(this);
                          ^
/home/aaronmt/Mozilla/Mozilla-Central/mobile/android/base/TabsTray.java:91: warning: [static] static method should be qualified by type name, Tabs, instead of by an expression
        tabs.registerOnTabsChangedListener(this);
            ^
/home/aaronmt/Mozilla/Mozilla-Central/mobile/android/base/TabsTray.java:117: warning: [static] static method should be qualified by type name, Tabs, instead of by an expression
        Tabs.getInstance().unregisterOnTabsChangedListener(this);
                          ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
6 warnings
make[6]: *** [classes.dex] Error 1

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 606262 [details] [diff] [review]
Patch

Review of attachment 606262 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I'll make sure to use "static" method properly, going forward.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9cfe4457573

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d9cfe4457573