Robocop: Write tests for frecency code

RESOLVED WONTFIX

Status

()

Firefox for Android
Testing
P5
normal
RESOLVED WONTFIX
6 years ago
4 months ago

People

(Reporter: Margaret, Assigned: gbrown)

Tracking

Trunk
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-fennec1.0 -)

Details

(Reporter)

Description

6 years ago
Follow-up to bug 704977. We can probably look at desktop tests to see how they did this. This will also become more important when we add bookmarks to the aweseomebar queries, and if we store frecency in the DB.
I think a good start would to just write a couple of tests that

1. Add a known history/bookmarks set
2. Use filter function to query
3. Assert if the results are what's expected (especially the order of the elements)

Should very simple to write those by inhering ContentProviderTest and using mResolver (the MockContentResolver used by ContentProviderTest) as the resolver in the BrowserDB API.
(Reporter)

Updated

6 years ago
Assignee: nobody → margaret.leibovic
(Reporter)

Comment 2

6 years ago
Can I just import BrowserDB into my test file to use the filterAllSites API, or do I need to do something else to get at that?
(Reporter)

Comment 3

6 years ago
(In reply to Margaret Leibovic [:margaret] from comment #2)
> Can I just import BrowserDB into my test file to use the filterAllSites API,
> or do I need to do something else to get at that?

Oh, nevermind, I see what you did in with a class loader bug 730105.
(Reporter)

Updated

6 years ago
Summary: Write tests for frecency code → Robocop: Write tests for frecency code
blocking-fennec1.0: --- → -

Updated

6 years ago
Blocks: 744859
(Reporter)

Comment 4

5 years ago
I never got around to this, unassigning in case someone else wants to take this on.
Assignee: margaret.leibovic → nobody
(Assignee)

Updated

4 months ago
Assignee: nobody → gbrown
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Component: General → Testing
Priority: -- → P5
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.