736177 - No scroll indicators

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Martijn Wargers (dead)]

Steps to reproduce:
- Start up Fennec
- Type in bbc.co.uk and press enter


Expected result:
- The resulting page should give scroll indicators while panning

Actual result:
- No scroll indicators while panning. When zooming in, I suddenly see horizontal scroll indicators on that site, but no vertical scroll indicator to be seen.

Tested on the HTC Desire HD, Android 2.3.5 and Samsung Galaxy Nexus, Android 4.0.2.

Comment 1

[Martijn Wargers (dead)]

I'm not seeing this in a Fennec13a build from 2012-03-15, so I think this is because of the Maple merge.

Comment 2

[Martijn Wargers (dead)]

Sometimes this seems to work fine.
However, I tested this with a clean profile on the HTC Desire HD and I can reproduce it all the time that way.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

More QA wanted. Need STR.

Comment 4

[Aaron Train [:aaronmt]]

I don't see scroll indicators at all.

STR as simple as visiting any site and scrolling (i.e, target.com, theverge.com, etc ...)

--
Nightly (03/19), Galaxy Nexus (Android 4.0.2)

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I've also been seeing this occasionally. It doesn't happen all the time, though. I looked over the code and I don't see any obvious problems. My current hypothesis is that it's related to bug 728961, and that some of the time our GL state is messed up such that when we go to draw the scrollbars in Java, they just don't show up.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I have only seen the scroll bar once when testing this out over 3 devices; loading multiple times.  Not sure exactly what's causing the difference

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Scroll bar can be consistently seen on 2/23/2012 build maple
Scroll bar can be consistently seen on 2/29/2012 build nightly
Scroll bar can be consistently seen on 03/12/2012 build nightly
Scroll bar can be consistently seen on 3/14/2012 build nightly
Scroll bar is inconsistently seen on 3/15/2012 build nightly

Scroll bar can be consistently seen on 3/13/2012 build maple.
Scroll bar is inconsistently seen on 3/14/2012 build maple.

Looks like the issue started on maple between 3/13 and 3/14

Comment 8

[Kartikaya Gupta (email:[e-mail])]

For reference, this is the range from the maple nightly build of the 13th and the 14th.

http://hg.mozilla.org/projects/maple/pushloghtml?fromchange=16e04eaadc14&tochange=177a960d5595

Since the scrollbar was fine on the m-c 14th nightly build (c71845b3b2a6) that I think eliminates all the csets merged in from m-c.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

I'll bisect further with the tinderbuilds builds at http://stage.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/maple-android/ to see which cset caused this.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

The build at http://stage.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/maple-android/1331686893/ has no vertical scrollbar when loading timecube.com, but the build at http://stage.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/maple-android/1331677393/ seems to be fine.

This points to http://hg.mozilla.org/projects/maple/rev/799af2f4aaf2 as the culprit. snorp, any ideas?

Comment 11

[Jeff Muizelaar [:jrmuizel]]

This seems to be caused by this hunk:

         GeckoAppShell.registerGeckoEventListener("Viewport:Update", this);
 
         view.setListener(this);
+        view.setLayerRenderer(mLayerRenderer);
         layerController.setRoot(mRootLayer);
 
         sendResizeEventIfNecessary(true);

Comment 12

[Jeff Muizelaar [:jrmuizel]]

We get scrollbars back if we don't set the first LayerRenderer. We're going to switch to having only one LayerRenderer and remove the LayerRenderer that is used for the Placeholder stuff. See bug 740146.

Comment 13

[Aaron Train [:aaronmt]]

So I've been seeing scroll-bars fine for the past day or so, at least on my Galaxy Nexus ... is this not entirely fixed?

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Patches that address this are in the works, but I don't think anything has landed yet. Unless fixing one or more of the GL crasher bugs took care of this too.

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Maybe this got fixed by bug 740146. I see scrollbars now too.

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Kartikaya Gupta (:kats) from comment #14)
> Patches that address this are in the works, but I don't think anything has
> landed yet. Unless fixing one or more of the GL crasher bugs took care of
> this too.

what patches do you think would be fixing this?

qawanted to test more extensively and see if we can still resolve this as WFM now.

Comment 17

[Tony Chung [:tchung]]

broken: 3/28/2012 build: changeset 244991519f53
works: 3/29/2012 build: changeset 1965a2c89d61

Something in here?

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=244991519f53&tochange=1965a2c89d61

Comment 18

[Martijn Wargers (dead)]

I've tested on the HTC Desire HD, Samsung Galaxy SII and the Samsung Galaxy Nexus. They all show the scroll indicators.

Jeff, the bug you mentioned in comment 12, is that the correct bug?
Anyway, I think this can be marked worksforme.

Comment 19

[Kartikaya Gupta (email:[e-mail])]

(In reply to Brad Lassey [:blassey] from comment #16)
> 
> what patches do you think would be fixing this?
> 

Based on the regression range, http://hg.mozilla.org/mozilla-central/rev/72a3e44395b2 is the most likely candidate to have fixed this. At the time though I though jrmuizel had a different fix for the scroll bar issue.

Comment 20

[microrffr]

this bug happens when bug 739046 happens.