The default bug view has changed. See this FAQ.

Wifi: Fix handling of passwords

RESOLVED FIXED

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 606308 [details] [diff] [review]
Patch

The version of the wifi patch that landed mishandles passwords for networks that we want to reconnect to, but don't want to update the password for. In the patch, I also update our internal representation of the network when we update it.
Attachment #606308 - Flags: review?(jones.chris.g)
Comment on attachment 606308 [details] [diff] [review]
Patch

>diff --git a/dom/wifi/nsWifiWorker.js b/dom/wifi/nsWifiWorker.js

>@@ -1438,6 +1452,7 @@ nsWifiWorker.prototype = {
>         networkReady();
>       }).bind(this));
>     } else {
>+      privnet.disabled = 0;

What is this doing?

The rest looks OK.
Attachment #606308 - Flags: review?(jones.chris.g)
(Assignee)

Comment 2

5 years ago
(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)
> >+      privnet.disabled = 0;
> 
> What is this doing?

By default, networks added by add_network are disabled and need an explicit enableNetwork call to enable them. However, here we do:

add_network
set_network_config
save_config
enable_network (and disable others)

which means that wpa_supplicant saves the network as being disabled. Because we want our networks to be enabled by default, we want to make sure to enable the network before the save_config. This ensures that the new network is remembered as being enabled.
(Assignee)

Comment 3

5 years ago
Comment on attachment 606308 [details] [diff] [review]
Patch

I'll add a comment to that effect before checkin.
Attachment #606308 - Flags: review?(jones.chris.g)
Comment on attachment 606308 [details] [diff] [review]
Patch

r=me with comment added
Attachment #606308 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ca1b5de7c0eb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.