Closed
Bug 736205
Opened 13 years ago
Closed 13 years ago
GLController.disposeGLContext never destroys the GL context
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox13 affected, firefox14 fixed)
RESOLVED
FIXED
Firefox 14
People
(Reporter: ajuma, Assigned: ajuma)
Details
Attachments
(1 file)
|
1.36 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
We're calling eglDestroyContext when mEGLContext is null, rather than when it's not null.
|
Assignee | |
Comment 1•13 years ago
|
||
This fixes the null check, and also prevents us from releasing mEGLDisplay and mEGLConfig when destroying the context (since they're still perfectly usable, and if we needlessly release them here we'll have to recreate them later in provideEGLSurface() -- we weren't running into this before simply because the code wasn't being reached due to the backwards null check).
Attachment #606317 -
Flags: review?(bgirard)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 606317 [details] [diff] [review]
Make GLController.disposeGLContext actually destroy the context.
Nice find
Attachment #606317 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Target Milestone: --- → Firefox 14
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
|
||
Updated•12 years ago
|
tracking-fennec: ? → ---
|
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•