Closed Bug 736211 Opened 9 years ago Closed 1 year ago
[New Tab Page] Users should be able to replace pinned sites by dragging
let the tabs be indexed top left to bottom right starting from 0. Suppose you have some thumbnail pinned at position 4 and 5. Now you drag the thumbnail from position 8 to position 6. (Assume that position 7 is filled) Then the tabs from position 4 and 5 gets shifted to position 3 and 4 resp. and tab on position 6 goes to 5. This should not happen as 4 and 5 were pinned, instead, 6 should have gone directly to position 3. This was correct in previous layout.
I'm having a hard time understanding/reproducing your STR. Could you maybe provide a screencast of this? (In reply to Girish Sharma from comment #0) > This was correct in previous layout. Did you try? I'm pretty sure I didn't change anything wrt to positioning while dragging.
Yes, this was earlier also. Also this only happens when the new position already had a pinned tab. Even though the new position has pinned tab, and we are trying to move another tab to that position, it should not change the position of other pinned tabs.
Summary: New Layout for NTP does not respect pinned thumbnails while dragging others. → New Tab Page does not respect other pinned thumbnails while dragging another thumbnail to a pinned position.
So if the first two thumbnails are pinned (upper left and upper middle), moving the middle left thumbnail to the upper left thumbnail will also shift the middle upper thumbnail's (pinned) position. I would also expect it the middle upper thumbnail to retain its position in this case.
(In reply to Virgil Dicu [:virgil] [QA] from comment #3) > So if the first two thumbnails are pinned (upper left and upper middle), > moving the middle left thumbnail to the upper left thumbnail will also shift > the middle upper thumbnail's (pinned) position. > > I would also expect it the middle upper thumbnail to retain its position in > this case. Yes, every thumb except the one at the destination should remain at its position if it is pinned.
I implemented the current behavior intentionally so that adjacent pinned sites are handled as "blocks" and you're moving not a single pinned site but a block of sites. The rationale behind this is that it's hard to tell what to do with the pinned site that should be moved out of the way. If we temporarily "unpin" it this could result in the whole grid shifting around (e.g. it's actually #1 by frecency but the user pinned it at position #5) or the site completely disappearing (because it's not anymore on the grid or was dragged onto it).
Okay , then what about this situation : All the tabs are pinned, all nine of them , and I drag a new link onto the top middle tab. But to my surprise, the bottom right tab gets deleted, which was my favorite site and I did not want to delete that,I wanted to delete the top middle one, that's why I dragged the new link over that.
Yeah that's valid use case but it's hard to tell whether people want to replace a pinned site or just insert a new pinned site and which sites are more important to them than others. We have to make some assumptions based on the position of the site. I'll assume if your favorite site is #9 you're doing it wrong ;)
No, that is not the point, point is that if something is pinned, then why is it getting removed without my intent. All nine can be my favorite, and I got a new favorite to replace some other tab, but some altogether different tab gets removed. IMO pinned tabs should stay at their position unless someone is dragging something over a pinned tab, in that case only that pinned tab should occupy the next free or non pinned position or just disappear .
(In reply to Girish Sharma [:Optimizer] from comment #8) > No, that is not the point, point is that if something is pinned, then why is > it getting removed without my intent. All nine can be my favorite, and I got > a new favorite to replace some other tab, but some altogether different tab > gets removed. But you're clearly only wanting to replace thumbnails. Why shouldn't we enable people to insert thumbnails? Even with a grid of nine pinned sites you may want to re-arrange things after a while. We could probably use some more opinions on this. CC'ing some people involved in the newtab page from the beginning.
(In reply to Tim Taubert [:ttaubert] from comment #9) > But you're clearly only wanting to replace thumbnails. Why shouldn't we > enable people to insert thumbnails? Even with a grid of nine pinned sites > you may want to re-arrange things after a while. Yeah, you are right too, maybe there can be too different behaviors, one would be dragging a link/tab/etc. which could be dropped onto the thumbnail, and other would be in between any two of them. The second one would mean that he is inserting the tab, the first one would mean he is replacing the thumbnail. It would be really awesome to have this kind of flexibility.
Changing the title to better reflect the reporter's suggestion.
Summary: New Tab Page does not respect other pinned thumbnails while dragging another thumbnail to a pinned position. → [New Tab Page] Users should be able to replace pinned sites by dragging
Mass-move to Firefox::New Tab Page. Filter on new-tab-page-component.
Component: General → New Tab Page
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.