Closed Bug 736243 Opened 14 years ago Closed 6 years ago

Color should be shown in Calendar/Category dropdown in event dialog

Categories

(Calendar :: Dialogs, defect)

defect
Not set
normal

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
83 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: Fallen, Assigned: darktrojan, Mentored)

References

Details

(Whiteboard: [lang=css])

Attachments

(1 file, 2 external files)

This would make it easier to see if you are creating an event in the right calendar. The same could be done with the category dropdown, but mind bug 316927.
Hi, Can i Be assigned this bug? Thanks
Sure! Please email me or meet me on irc.mozilla.org / #calendar if you need help getting started.
Assignee: nobody → vandrew88
Status: NEW → ASSIGNED
Hi Philip and Andrew, My partner and I were wondering if we could help with this bug as well. Thanks, Andrew and Kevin
Hi, If it's ok with philip.. I would like to work on this bug with my partner. Mainly because this is for our class project.
Since Andrew from comment 1 was first, I think he should get this bug. Andrew from comment 3 and Kevin, if you need help finding an alternative bug, please let me know.
Status: ASSIGNED → NEW
Assignee: vandrew88 → nobody
Andrew, no longer interested on working on this bug?
Hi Philipp, May I please be assigned to this bug to work on with Kevinhuynh1@gmail.com? Thanks, Andrew
I'll do so now, maybe it fits well since iirc you are also doing the other category dropdown patch. If the assign-to-nobody was a mistake then we'll have to rediscuss.
Assignee: nobody → andrewmaibui
Status: NEW → ASSIGNED
Can someone check if this is on track with what's needed for this bug?
Hi Kevin, Andrew, unfortunately its not as easy as you put it. The menuitem doesn't automatically display the color on the item and you don't want a CSS rule for each color. What you probably have to do is add a custom binding that puts a color box in front of the label. This would be similar to this binding: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/menu.xml?force=1#218 Then you need to dynamically add rules that set the color. We have done this similarly twice before, so it might make sense to generalize a function that can be called from all places: http://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-views.js#457 http://mxr.mozilla.org/comm-central/source/calendar/base/modules/calPrintUtils.jsm#54 This is how it works for the more simple calendar dropdown. The category dropdown is of course a bit different given the patch from bug 316927. With that patch applied, I think all you need to do is make the listbox a <richlistbox> and create a binding that extends a richlistitem, that contains the color box. With all that noted, are you still interested in fixing this bug? If not, Amod would like to take over. If you don't let me know within the following few days, I will re-assign this bug.
Can you confirm that you're still working on this bug?
Flags: needinfo?(andrewmaibui)
Assignee: andrewmaibui → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(andrewmaibui)
Hi Philippe May i please be assign to this bug if Andrew is not working on it any more. i would like to work on this , can you please assign it to me. thank you. Zulfa
Hi Zulfa, you are welcome to work on this bug. Let me know (via email if you like) what kind of help you need to get started (help building Lightning? help figuring out where in the code to start? ...)
Assignee: nobody → allyz
Status: NEW → ASSIGNED
Hi Philipp, can you help me get started on fixing this bug
Mentor: philipp
Whiteboard: [good first bug][mentor=Fallen][lang=css] → [good first bug][lang=css]
Can i work on this ?
Zulfa, I hope I had replied to you via private email on your comment. Please excuse if I haven't. You have dibs on fixing this one if you would still like to, but I'll reassign for now until you answer. Shekhar, given we hear nothing from Zulfa, you should be good to go to fix this one. Please visit irc.mozilla.org #calendar and look for me for help on getting started. The bug already contains a lot of information on the bug on how to fix it, the rest is just setting up a dev environment which you can read about at https://developer.mozilla.org/En/Simple_Thunderbird_build There are currently some build issues, so some tweaking might be required to make things running. You can ask about in this in #calendar or #maildev.
Assignee: allyz → shekharstudy
Ok , I want some more information about this .Can any one help me ?
Please catch me on IRC as mentioned above, this makes it easier to communicate. If you need help getting connected, please see https://wiki.mozilla.org/IRC The channel you want to visit is #calendar and my nickname is Fallen.
Hi is anybody currently working on this bug, I would like to work on this as my first bug.
Akshay, it doesn't look like anyone's owrking on it right now. Go for it, and let me know how if you have any questions.
Status: ASSIGNED → NEW
(In reply to Mike Hoye [:mhoye] from comment #21) > Akshay, it doesn't look like anyone's owrking on it right now. Go for it, > and let me know how if you have any questions. Hi Mike thanks for your reply, can you please advise how I can get started working on this.
Hi Mike thanks for your reply, can you please advise how I can get started working on this.
Flags: needinfo?(mhoye)
Sorry for the delay, Akshay - first thing you'll need to do is probably to download the Lightning addons - https://www.mozilla.org/en-US/projects/calendar/ - but I'd start by asking on IRC where the Lightning source code lives and how to contribute to it. People in the #thunderbird or #introduction channels be able to help you.
Flags: needinfo?(mhoye)
Hi, I am new to fixing bugs and I would like to work on the bug please.
This bug is still assigned to Shekhar Prasad Rajak but the status has been recently set to New so I think that no one is working on this. (In reply to Akshay from comment #23) > Hi Mike thanks for your reply, can you please advise how I can get started > working on this. Akshay, I also send you an email just in case you didn't find in another way some basic information. Could you please confirm if you are working on this bug? (In reply to Pas from comment #25) > Hi, I am new to fixing bugs and I would like to work on the bug please. Hi Pas, if Akshay is not working on this bug you can take the assignment. The way to fix this bug is well explained by Philipp Kewisch in comment 11, if you need informations about how to start I can send you an email or you can ask to Philipp Kewisch, if you have many questions I suggest you to join the chat irc.mozilla.org #calendar and ask for Philipp Kewisch (nickname: Fallen).
Flags: needinfo?(akshay_verma)
(In reply to Decathlon from comment #26) > This bug is still assigned to Shekhar Prasad Rajak but the status has been > recently set to New so I think that no one is working on this. > > (In reply to Akshay from comment #23) > > Hi Mike thanks for your reply, can you please advise how I can get started > > working on this. > > Akshay, I also send you an email just in case you didn't find in another way > some basic information. > Could you please confirm if you are working on this bug? > > > (In reply to Pas from comment #25) > > Hi, I am new to fixing bugs and I would like to work on the bug please. > > Hi Pas, if Akshay is not working on this bug you can take the assignment. > The way to fix this bug is well explained by Philipp Kewisch in comment 11, > if you need informations about how to start I can send you an email or you > can ask to Philipp Kewisch, if you have many questions I suggest you to join > the chat irc.mozilla.org #calendar and ask for Philipp Kewisch (nickname: > Fallen). Hi sorry for the late reply, I can confirm I am no longer working on this bug, I did not make much progress, I have finished my university assignment so please go ahead.
Flags: needinfo?(akshay_verma)
Hello, I'd like to work on this as a first bug, if no one else is working on it.
Hi Paul, I'm a bit confused here. Many asked to work on this but I see no proposed patch, at the end I think that nobody is working on this issue, so please go ahead. Please, read every previous comment, and in particular comment 11, and ask (also by email) if you need any kind of information :)
Assignee: shekharstudy → paulmorriscoder
Status: NEW → ASSIGNED
Keywords: good-first-bug
Whiteboard: [good first bug][lang=css] → [lang=css]

The patch above only does the calendar list, not the category list, but it's probably fairly easy to do with the same approach. Alessandro, I've tried to line up the icon and text in the top of the menulist with those in the drop-down, but I've only tested it on Linux so it may not be right elsewhere.

Assignee: paul → geoff

Comment on attachment 9177840 [details]
Bug 736243 - Show calendar colours in the calendar selection menulist. r?aleca

Please check this looks good.

Attachment #9177840 - Flags: ui-review?(richard.marti)

Comment on attachment 9177840 [details]
Bug 736243 - Show calendar colours in the calendar selection menulist. r?aleca

Looks good on Windows too.

Attachment #9177840 - Flags: ui-review?(richard.marti) → ui-review+
Target Milestone: --- → 83 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3ced39c1e2b0
Show calendar colours in the calendar selection menulist. r=aleca

Adds a colour for each selected category. When no categories are selected, it looks just like an ordinary menulist.
When one category is selected, the colour blob lines up with that in the calendar selection menulist.

Attachment #9179175 - Flags: ui-review?(richard.marti)
Attachment #9179175 - Flags: ui-review?(richard.marti) → ui-review+
Keywords: leave-open

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/398b199601de
Show category colours in the category selection menulist. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: