CreateForNativePixmapSurface appears unused

RESOLVED FIXED in mozilla17

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
GLContextProvider*::CreateForNativePixmapSurface is unused, and should be removed. Even in the only case where we still use Pixmaps (non-tier-1 platforms using X11 and EGL) we do not use this function.
(Assignee)

Comment 1

6 years ago
Created attachment 606414 [details] [diff] [review]
Remove CreateForNativePixmapSurface from GLContextProviders

Ignore that the patch file is named 'break-glx'.
Assignee: nobody → jgilbert
Attachment #606414 - Flags: review?(bjacob)
Comment on attachment 606414 [details] [diff] [review]
Remove CreateForNativePixmapSurface from GLContextProviders

Review of attachment 606414 [details] [diff] [review]:
-----------------------------------------------------------------

R=me since unused code is unused, but let's ask Oleg if perhaps Meego might have local patches that rely on this.
Attachment #606414 - Flags: review?(bjacob) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [rplus]
(Assignee)

Comment 3

5 years ago
Created attachment 646719 [details] [diff] [review]
un-bitrotted version

Carry forward r+.
Attachment #606414 - Attachment is obsolete: true
Attachment #646719 - Flags: review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f58214b53c9a
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
(Assignee)

Updated

5 years ago
Whiteboard: [rplus]
https://hg.mozilla.org/mozilla-central/rev/f58214b53c9a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.