Closed Bug 736298 Opened 8 years ago Closed 7 years ago

CreateForNativePixmapSurface appears unused

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(1 file, 1 obsolete file)

GLContextProvider*::CreateForNativePixmapSurface is unused, and should be removed. Even in the only case where we still use Pixmaps (non-tier-1 platforms using X11 and EGL) we do not use this function.
Ignore that the patch file is named 'break-glx'.
Assignee: nobody → jgilbert
Attachment #606414 - Flags: review?(bjacob)
Comment on attachment 606414 [details] [diff] [review]
Remove CreateForNativePixmapSurface from GLContextProviders

Review of attachment 606414 [details] [diff] [review]:
-----------------------------------------------------------------

R=me since unused code is unused, but let's ask Oleg if perhaps Meego might have local patches that rely on this.
Attachment #606414 - Flags: review?(bjacob) → review+
Whiteboard: [rplus]
Carry forward r+.
Attachment #606414 - Attachment is obsolete: true
Attachment #646719 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f58214b53c9a
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
Whiteboard: [rplus]
https://hg.mozilla.org/mozilla-central/rev/f58214b53c9a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.