Last Comment Bug 736298 - CreateForNativePixmapSurface appears unused
: CreateForNativePixmapSurface appears unused
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Jeff Gilbert [:jgilbert]
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2012-03-15 15:58 PDT by Jeff Gilbert [:jgilbert]
Modified: 2012-07-28 18:35 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Remove CreateForNativePixmapSurface from GLContextProviders (6.90 KB, patch)
2012-03-15 17:54 PDT, Jeff Gilbert [:jgilbert]
jacob.benoit.1: review+
Details | Diff | Splinter Review
un-bitrotted version (7.98 KB, patch)
2012-07-27 14:27 PDT, Jeff Gilbert [:jgilbert]
jgilbert: review+
Details | Diff | Splinter Review

Description Jeff Gilbert [:jgilbert] 2012-03-15 15:58:41 PDT
GLContextProvider*::CreateForNativePixmapSurface is unused, and should be removed. Even in the only case where we still use Pixmaps (non-tier-1 platforms using X11 and EGL) we do not use this function.
Comment 1 Jeff Gilbert [:jgilbert] 2012-03-15 17:54:14 PDT
Created attachment 606414 [details] [diff] [review]
Remove CreateForNativePixmapSurface from GLContextProviders

Ignore that the patch file is named 'break-glx'.
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2012-03-20 04:16:45 PDT
Comment on attachment 606414 [details] [diff] [review]
Remove CreateForNativePixmapSurface from GLContextProviders

Review of attachment 606414 [details] [diff] [review]:

R=me since unused code is unused, but let's ask Oleg if perhaps Meego might have local patches that rely on this.
Comment 3 Jeff Gilbert [:jgilbert] 2012-07-27 14:27:56 PDT
Created attachment 646719 [details] [diff] [review]
un-bitrotted version

Carry forward r+.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-28 18:35:57 PDT

Note You need to log in before you can comment on or make changes to this bug.