Closed
Bug 736298
Opened 13 years ago
Closed 13 years ago
CreateForNativePixmapSurface appears unused
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(1 file, 1 obsolete file)
|
7.98 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
GLContextProvider*::CreateForNativePixmapSurface is unused, and should be removed. Even in the only case where we still use Pixmaps (non-tier-1 platforms using X11 and EGL) we do not use this function.
|
Assignee | |
Comment 1•13 years ago
|
||
Ignore that the patch file is named 'break-glx'.
Assignee: nobody → jgilbert
Attachment #606414 -
Flags: review?(bjacob)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 606414 [details] [diff] [review]
Remove CreateForNativePixmapSurface from GLContextProviders
Review of attachment 606414 [details] [diff] [review]:
-----------------------------------------------------------------
R=me since unused code is unused, but let's ask Oleg if perhaps Meego might have local patches that rely on this.
Attachment #606414 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [rplus]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Carry forward r+.
Attachment #606414 -
Attachment is obsolete: true
Attachment #646719 -
Flags: review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [rplus]
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•