73640 - uriloader should support true weak references

Status: VERIFIED FIXED

(Core :: Networking, defect, P2)

Description

[Alec Flett]

I was trying to re-implement the browser's nsIURIContentListener (part of the
evil nsBrowserInstance) but I kept getting bit by the fact that
nsIURILoader::RegisterContentListener keeps a non-refcounted pointer to the
object passed in.. this doesn't play nicely with JS and results in a crash when
you read a mail message.
so, I fixed it and it's callers. patches forthcoming.

Comment 1

[Alec Flett]

Attachment: add weak ref support to uriloader

Comment 2

[Alec Flett]

Attachment: make nsMsgMailWindow support weak refs

Comment 3

[Alec Flett]

Attachment: make psm support weak refs

Comment 4

[Alec Flett]

the current nsBrowserInstance already supports weak refs, so I didn't have to
change that. I will attach the C++->JS conversion in bug 46200.

Comment 5

[Scott MacGregor]

you and all your white space changes =)

sr=mscott

Comment 6

[Peter "jag" Annema]

r=jag with the understanding that nsBrowserInstance should be changed if you
weren't ripping that out of it already (bug 46200)...

Comment 7

[Alec Flett]

fix is in

Comment 8

[Blake Ross]

marking fixed.

Comment 9

[Bradley Baetz (:bbaetz)]

VERIFIED with lxr