Closed
Bug 73640
Opened 25 years ago
Closed 25 years ago
uriloader should support true weak references
Categories
(Core :: Networking, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: alecf, Assigned: alecf)
References
Details
(Whiteboard: fix in hand)
Attachments
(3 files)
|
7.91 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.35 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.31 KB,
patch
|
Details | Diff | Splinter Review |
I was trying to re-implement the browser's nsIURIContentListener (part of the
evil nsBrowserInstance) but I kept getting bit by the fact that
nsIURILoader::RegisterContentListener keeps a non-refcounted pointer to the
object passed in.. this doesn't play nicely with JS and results in a crash when
you read a mail message.
so, I fixed it and it's callers. patches forthcoming.
|
Assignee | |
Comment 1•25 years ago
|
||
|
|
Assignee | |
Comment 2•25 years ago
|
||
|
|
Assignee | |
Comment 3•25 years ago
|
||
|
|
Assignee | |
Comment 4•25 years ago
|
||
the current nsBrowserInstance already supports weak refs, so I didn't have to
change that. I will attach the C++->JS conversion in bug 46200.
Blocks: 46200
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: fix in hand
Target Milestone: --- → mozilla0.9
|
|
||
Comment 5•25 years ago
|
||
you and all your white space changes =)
sr=mscott
|
||
Comment 6•25 years ago
|
||
r=jag with the understanding that nsBrowserInstance should be changed if you
weren't ripping that out of it already (bug 46200)...
|
|
Assignee | |
Comment 7•25 years ago
|
||
fix is in
|
|
||
Comment 8•25 years ago
|
||
marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•