736432 - IonMonkey: ARM can flush the wrong cache

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Marty Rosenberg [:mjrosenb]]

Attachment: /home/mrosenberg/patches/more_flushes-r0.patch

pasted directly from IRC:

04:21 < mjrosenb> if there is a load that we want to patch
04:21 < mjrosenb> then patching it will involve overwriting two instructions
04:21 < mjrosenb> and we explicitly flush two instructions worth of data
04:22 < mjrosenb> but, if there was a pool in between them, we'll flush the first movw, and the pool header
04:22 < mjrosenb> err, the branch around the pool, not the header

Comment 1

[Jacob Bramley [:jbramley]]

Comment on attachment 606529 [details] [diff] [review]
/home/mrosenberg/patches/more_flushes-r0.patch

I think you forgot to qrefresh. Aside from a commit comment, the patch is empty.

Comment 2

[Marty Rosenberg [:mjrosenb]]

Attachment: flush twice

This patch looks like it also has the removal of an NYI, which I'm not going to commit.

Comment 3

[Jacob Bramley [:jbramley]]

Comment on attachment 608667 [details] [diff] [review]
flush twice

Review of attachment 608667 [details] [diff] [review]:
-----------------------------------------------------------------

Spot on!

(Well, except for the NYI thing.)

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Marty says this was fixed along with a cache flushing overhaul we did a few weeks ago.