The default bug view has changed. See this FAQ.

replace abouthome/noise.png with reasonably sized copy from about:newtab

RESOLVED FIXED in Firefox 13

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({footprint})

Trunk
Firefox 14
footprint
Points:
---

Firefox Tracking Flags

(firefox13 fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 606543 [details] [diff] [review]
part 1
Attachment #606543 - Flags: review?(mak77)
(Assignee)

Comment 1

5 years ago
Created attachment 606544 [details] [diff] [review]
part 2

11 KB -> 2.1 KB
Attachment #606544 - Flags: review?(mak77)
(Assignee)

Updated

5 years ago
Keywords: footprint
hm, the images look quite different to me, is winstripe one just a "merge" of abouthome one and the background?
(Assignee)

Comment 3

5 years ago
No, both images are similarly used in combination with a CSS background color and a gradient. The background colors are actually the same and about:home has a slightly brighter gradient.
Comment on attachment 606544 [details] [diff] [review]
part 2

I don't think there's anything to review here, the changes are quite trivial. Though this needs design review imo, I didn't make that theme so I may miss reasons for a certain gradient compared to another one.
Forwarding to Stephen sounds like the best choice.
Attachment #606544 - Flags: review?(mak77) → review?(shorlander)
Comment on attachment 606543 [details] [diff] [review]
part 1

r+ on the idea to replace this image, the current one is quite too big.
Attachment #606543 - Flags: review?(mak77) → review+
(Assignee)

Comment 6

5 years ago
The _CSS_ gradient is slightly brighter in about:home. The images don't contain gradients.
Attachment #606544 - Flags: review?(shorlander) → review+
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/12e9afe49759
http://hg.mozilla.org/integration/mozilla-inbound/rev/d5c0cec1028a
Target Milestone: --- → Firefox 14
(Assignee)

Updated

5 years ago
Attachment #606543 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 8

5 years ago
Comment on attachment 606544 [details] [diff] [review]
part 2

trivial copy from about:newtab's noise.png to about:home's noise png. both images are new on aurora.
Attachment #606544 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/12e9afe49759
https://hg.mozilla.org/mozilla-central/rev/d5c0cec1028a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 711157

Updated

5 years ago
Attachment #606543 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
Attachment #606544 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 10

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/5394e65e7c9b
http://hg.mozilla.org/releases/mozilla-aurora/rev/a740b362df50
status-firefox13: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.