736444 - replace abouthome/noise.png with reasonably sized copy from about:newtab

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: part 1

Comment 1

[Dão Gottwald [:dao]]

Attachment: part 2

11 KB -> 2.1 KB

Comment 2

[Marco Bonardo [:mak]]

hm, the images look quite different to me, is winstripe one just a "merge" of abouthome one and the background?

Comment 3

[Dão Gottwald [:dao]]

No, both images are similarly used in combination with a CSS background color and a gradient. The background colors are actually the same and about:home has a slightly brighter gradient.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 606544 [details] [diff] [review]
part 2

I don't think there's anything to review here, the changes are quite trivial. Though this needs design review imo, I didn't make that theme so I may miss reasons for a certain gradient compared to another one.
Forwarding to Stephen sounds like the best choice.

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 606543 [details] [diff] [review]
part 1

r+ on the idea to replace this image, the current one is quite too big.

Comment 6

[Dão Gottwald [:dao]]

The _CSS_ gradient is slightly brighter in about:home. The images don't contain gradients.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/12e9afe49759
http://hg.mozilla.org/integration/mozilla-inbound/rev/d5c0cec1028a

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 606544 [details] [diff] [review]
part 2

trivial copy from about:newtab's noise.png to about:home's noise png. both images are new on aurora.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/12e9afe49759
https://hg.mozilla.org/mozilla-central/rev/d5c0cec1028a

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/5394e65e7c9b
http://hg.mozilla.org/releases/mozilla-aurora/rev/a740b362df50