Closed Bug 736456 Opened 8 years ago Closed 8 years ago

captureAndStore callback may try to access destroyed browser

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed

People

(Reporter: mak, Assigned: mak)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

aBrowser.currentURI is used in an internal callback, but at that point it may be null, should be cached earlier
Attached patch patch v1.0Splinter Review
Attachment #606565 - Flags: review?(ttaubert)
Comment on attachment 606565 [details] [diff] [review]
patch v1.0

Review of attachment 606565 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like "url" probably more as a variable name... but anyway, thanks!

r=me
Attachment #606565 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/integration/fx-team/rev/1b34bd4a5425
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/1b34bd4a5425
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Comment on attachment 606565 [details] [diff] [review]
patch v1.0

[Approval Request Comment]
User impact if declined: possibly errors in the console
Testing completed (on m-c, etc.): on m-c since 10+ days
Risk to taking this patch (and alternatives if risky): very low risk
String changes made by this patch: none

This blocks the landing of bug 705911 on Aurora and we should backport it as well.
Attachment #606565 - Flags: approval-mozilla-aurora?
Comment on attachment 606565 [details] [diff] [review]
patch v1.0

(In reply to Tim Taubert [:ttaubert] from comment #5)
> User impact if declined: possibly errors in the console

This isn't typically justification for uplift (not really user impact), but since this is a new FF13 feature, the patch is super low risk, and we're only halfway through Aurora, we'll take this fix.
Attachment #606565 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.