736456 - captureAndStore callback may try to access destroyed browser

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Marco Bonardo [:mak]]

aBrowser.currentURI is used in an internal callback, but at that point it may be null, should be cached earlier

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 606565 [details] [diff] [review]
patch v1.0

Review of attachment 606565 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like "url" probably more as a variable name... but anyway, thanks!

r=me

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/1b34bd4a5425

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/1b34bd4a5425

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 606565 [details] [diff] [review]
patch v1.0

[Approval Request Comment]
User impact if declined: possibly errors in the console
Testing completed (on m-c, etc.): on m-c since 10+ days
Risk to taking this patch (and alternatives if risky): very low risk
String changes made by this patch: none

This blocks the landing of bug 705911 on Aurora and we should backport it as well.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 606565 [details] [diff] [review]
patch v1.0

(In reply to Tim Taubert [:ttaubert] from comment #5)
> User impact if declined: possibly errors in the console

This isn't typically justification for uplift (not really user impact), but since this is a new FF13 feature, the patch is super low risk, and we're only halfway through Aurora, we'll take this fix.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c6f1210231c1