The default bug view has changed. See this FAQ.

Cleanup and ease browser_480148.js

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Session Restore
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

unspecified
Firefox 14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The test is half sync half async, it calls all the runTest methods at once, and those end up being executed randomly at the same time, though each of those executeSoon on load.  While looking for frequent oranges, I compared 2 pgo runs, one failing and one succeeding, and this was one of the few tests behaving differently.
Since the scope of the test is quite different from opening tens of windows with tens of tabs at once and closing them at random order hoping to finish at the right time, I think it's worth to give it a path to follow.
(Assignee)

Comment 1

5 years ago
Created attachment 606593 [details] [diff] [review]
patch v1.0
Attachment #606593 - Flags: review?(paul)
Comment on attachment 606593 [details] [diff] [review]
patch v1.0

Review of attachment 606593 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/test/browser_480148.js
@@ +40,1 @@
>    requestLongerTimeout(2);

I wonder if we'll need to extend this timeout since the windows are opening sequentially. I guess we'll find out!
Attachment #606593 - Flags: review?(paul) → review+
(Assignee)

Comment 3

5 years ago
Sure, that's an easy change. thanks.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/06ffbf7b6518
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/06ffbf7b6518
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.