Closed
Bug 736519
Opened 12 years ago
Closed 12 years ago
jssubloader files are not packaged properly
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox11 unaffected, firefox12 unaffected, firefox13 fixed)
RESOLVED
FIXED
mozilla14
Tracking | Status | |
---|---|---|
firefox11 | --- | unaffected |
firefox12 | --- | unaffected |
firefox13 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
1.57 KB,
patch
|
khuey
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.75 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Bug 648125 added support for cache for js loaded with loadSubScript. Somehow (probably because so many scripts just fail in the xpcshell harness used to generate jsloader cache), it was never exercised until bug 697762 landed. Now, there is a jssubloader/185/resource/gre/chrome/toolkit/content/global/devtools/dbg-transport.js that ends up packaged. That file should obviously be in omni.jar.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
status-firefox11:
--- → unaffected
status-firefox12:
--- → unaffected
status-firefox13:
--- → affected
Comment 1•12 years ago
|
||
Do you want to dupe bug 732649 to this or vice versa?
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #606639 -
Flags: review?(khuey)
Attachment #606639 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•12 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Updated•12 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/68def3ab33b6
Comment 6•12 years ago
|
||
Please can you set the target milestone when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-) https://hg.mozilla.org/mozilla-central/rev/68def3ab33b6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 606639 [details] [diff] [review] Package jssubloader cache in omnijar [Approval Request Comment] Regression caused by combination of bug 648125 and bug 697762 User impact if declined: extra unused file shipped in tarballs/installers Risk to taking this patch (and alternatives if risky): none String changes made by this patch: none
Attachment #606639 -
Flags: approval-mozilla-aurora?
Comment 8•12 years ago
|
||
Comment on attachment 606639 [details] [diff] [review] Package jssubloader cache in omnijar [Triage Comment] Doesn't sound like this is absolutely necessary from the user's perspective, but given where we are in Aurora this should be OK to land.
Attachment #606639 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•12 years ago
|
||
Attachment #609641 -
Flags: review?(khuey)
Attachment #609641 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5a55d435ca
Assignee | ||
Comment 11•12 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/2ee0ace363aa
Comment 12•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #10) > https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5a55d435ca https://hg.mozilla.org/mozilla-central/rev/5a5a55d435ca
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•