Closed Bug 736519 Opened 11 years ago Closed 11 years ago

jssubloader files are not packaged properly

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 unaffected, firefox12 unaffected, firefox13 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla14
Tracking Flags:
Tracking Status
firefox11 --- unaffected
firefox12 --- unaffected
firefox13 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

Package jssubloader cache in omnijar
1.57 KB, patch
khuey
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Add jssubloader to removed-files
1.75 KB, patch
khuey
: review+
Details | Diff | Splinter Review 
Bug 648125 added support for cache for js loaded with loadSubScript. Somehow (probably because so many scripts just fail in the xpcshell harness used to generate jsloader cache), it was never exercised until bug 697762 landed.

Now, there is a jssubloader/185/resource/gre/chrome/toolkit/content/global/devtools/dbg-transport.js that ends up packaged. That file should obviously be in omni.jar.
Blocks: 697762, 648125
Do you want to dupe bug 732649 to this or vice versa?
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE

        Attachment #606639 -
        Flags: review?(khuey)

    
  
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

    
  
Status: REOPENED → ASSIGNED

    
    

    
  
Please can you set the target milestone when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-)

https://hg.mozilla.org/mozilla-central/rev/68def3ab33b6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14

    
    

    
  
Comment on attachment 606639 [details] [diff] [review]
Package jssubloader cache in omnijar

[Approval Request Comment]
Regression caused by combination of bug 648125 and bug 697762
User impact if declined: extra unused file shipped in tarballs/installers
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

        Attachment #606639 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 606639 [details] [diff] [review]
Package jssubloader cache in omnijar

[Triage Comment]
Doesn't sound like this is absolutely necessary from the user's perspective, but given where we are in Aurora this should be OK to land.

        Attachment #606639 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  


  

        Attachment #609641 -
        Flags: review?(khuey)

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.