736592 - Use getWeakReference instead of actual references to elements

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Use getWeakReference() calls when keeping the marionette-elements items so we don't have active references.

Make sure to run thorough tests, since test_findelement.py had been failing intermittently when I tried to push this change before, but I have not yet found out the cause.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: use getWeakReference

Testing this patch in try now: https://tbpl.mozilla.org/?tree=Try&rev=ac6222bf2ee9

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 734905 [details] [diff] [review]
use getWeakReference

Review of attachment 734905 [details] [diff] [review]:
-----------------------------------------------------------------

try looks good

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 734905 [details] [diff] [review]
use getWeakReference

Review of attachment 734905 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; if we're still concerned about intermittent failures, we could retrigger the Mn jobs in your try push like a dozen times.

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Landing in m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f728c08664a4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f728c08664a4

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/84f2fee5d8e8

Comment 7

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/2989e41714c2