736598 - Add support for the track element in the old HTML parser

Status: RESOLVED WONTFIX

(Core :: DOM: HTML Parser, defect)

Description

[Ralph Giles (:rillian)]

Bug 620664 added support for the HTML5 track element to parser/html. Not realizing there were two HTML parsers, I added support for the deprecated one in parser/htmlparser as well. 

This bug is about landing that patch.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No point, it's going away, and isn't used for web pages anyway.

Comment 2

[Ralph Giles (:rillian)]

Attachment: add the track element to the old parser and editor

Henri, you carefully explained to me at the all-hands under what circumstances the old parser is still used, but I'm afraid I've forgotten the details now. I'd like to know how necessary this is.

However, while we have the code in-tree, I think it makes sense to keep them up to date.

Comment 3

[Ralph Giles (:rillian)]

Well, I guess that answers the necessary question...

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 606732 [details] [diff] [review]
add the track element to the old parser and editor

The old parser is used for about:blank, Netscape bookmark import and Thunderbird message sanitization. After writing this comment, I'm going to start landing patches that obsolete the old message sanitization code. The bookmark import is on the verge of changing (and won't include <track> anyway). about:blank doesn't include <track>. So none of this is needed for *parsing*.

However, until bug 729046 is fixed, these tables are still used by nsHTMLEditUtils::IsContainer. But still, I think it doesn't make sense to land this. It would be so easy to make calls to nsHTMLEditUtils::IsContainer use !nsContentUtils::IsHTMLVoid instead that it makes more sense to do that than to keep nsHTMLEditUtils::IsContainer alive.