736652 - Zooming out on View Image to see it without scrollbars loses styling

Status: NEW

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Mardeg]

STR:
1. View or zoom any image to larger than the viewport
   eg. http://www.justcalendar.org/calendar/Blank-Calendar-2.jpg
2. Use a bookmarklet like the one from the URL field to apply a style
   eg. opacity, transform
3. Zoom the image out to see it all without needing to scroll

Expected Results:
Image retains applied style

Actual Results:
Image loses style

Comment 1

[Boris Zbarsky [:bzbarsky]]

ImageDocument::ShrinkToFit (which may be called when you "zoom the image" if you really mean "click the image") does this:

457   imageContent->SetAttr(kNameSpaceID_None, nsGkAtoms::style,
458                         NS_LITERAL_STRING("cursor: -moz-zoom-in"), true);

which would of course lose your styles.

I don't think there's necessarily a problem here; the basic "make it fit" styles the image needs here are not compatible with arbitrary styling, obviously....

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Though ImageDocument could relatively easily use the C++ equivalent of element.style.setProperty() and avoid the problem.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Possibly, yes.  RestoreImage would need changes too.

Comment 4

[Mardeg]

(In reply to Boris Zbarsky (:bz) from comment #1)
> ImageDocument::ShrinkToFit (which may be called when you "zoom the image" if
> you really mean "click the image") does this:

No I just meant zooming out with Ctrl - 
I hadn't tested the "click to fit"

Comment 5

[Boris Zbarsky [:bzbarsky]]

Ah, that might be hitting the RestoreImage() case, then.  Not sure.

Comment 6

[Mardeg]

This was first noted when testing the extension at
https://addons.mozilla.org/en-US/firefox/addon/flip-or-rotate-image/ in case anyone thought it was limited to bookmarklets.